Skip to content

Commit

Permalink
[torchrec] Fix undefined references issue
Browse files Browse the repository at this point in the history
- Fix undefined references issue
  • Loading branch information
q10 committed Jan 28, 2025
1 parent 8e5f5df commit 444d1e8
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 13 deletions.
16 changes: 4 additions & 12 deletions .github/workflows/unittest_ci_cpu.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,12 +47,14 @@ jobs:
conda create -y --name build_binary python=${{ matrix.python-version }}
conda info
python --version
conda run -n build_binary ldd --version
conda run -n build_binary python --version
conda install -n build_binary -y numpy
conda run -n build_binary \
pip install torch --index-url https://download.pytorch.org/whl/nightly/cpu
conda run -n build_binary \
python -c "import torch"
echo "torch succeeded"
python -c "import torch" && \
echo "torch succeeded"
conda run -n build_binary \
python -c "import torch.distributed"
conda run -n build_binary \
Expand All @@ -71,16 +73,6 @@ jobs:
conda run -n build_binary \
python -c "import numpy"
echo "numpy succeeded"
conda install -n build_binary -y pytest
conda run -n build_binary \
python -m pytest torchrec -v -s -W ignore::pytest.PytestCollectionWarning --continue-on-collection-errors \
--ignore-glob=**/test_utils/
echo "Starting C++ Tests"
conda install -n build_binary -y gxx_linux-64
conda run -n build_binary \
x86_64-conda-linux-gnu-g++ --version
conda install -n build_binary -c anaconda redis -y
conda run -n build_binary redis-server --daemonize yes
mkdir cpp-build
cd cpp-build
conda run -n build_binary cmake \
Expand Down
2 changes: 1 addition & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ include(FetchContent)

option(BUILD_TEST "Build C++ test binaries (need gtest and gbenchmark)" OFF)

add_definitions("-D_GLIBCXX_USE_CXX11_ABI=0")
add_definitions("-D_GLIBCXX_USE_CXX11_ABI=1")

add_subdirectory(torchrec/csrc)

Expand Down

0 comments on commit 444d1e8

Please sign in to comment.