Update batched_embedding_kernel #2702
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D66919716 |
|
This pull request was exported from Phabricator. Differential Revision: D66919716 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D66919716 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 26, 2025
Summary: After this diff stack: EmbeddingKernelConfig now supports adding embedding_table_int32_index_type and embedding_table_int32_offset_type to the fused_params. These are used downstream to determine whether the indices and offsets types for split_table_batched_embeddings_ops_training.py Differential Revision: D66919716
facebook-github-bot
force-pushed
the
export-D66919716
branch
from
294a6fc to
79dd60d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66919716 |
2 similar comments
|
This pull request was exported from Phabricator. Differential Revision: D66919716 |
|
This pull request was exported from Phabricator. Differential Revision: D66919716 |
Summary: After this diff stack: EmbeddingKernelConfig now supports adding embedding_table_int32_index_type and embedding_table_int32_offset_type to the fused_params. These are used downstream to determine whether the indices and offsets types for split_table_batched_embeddings_ops_training.py Differential Revision: D66919716
facebook-github-bot
force-pushed
the
export-D66919716
branch
from
79dd60d to
4b731b3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66919716 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
After this diff stack:
EmbeddingKernelConfig now supports adding embedding_table_int32_index_type and embedding_table_int32_offset_type to the fused_params.
These are used downstream to determine whether the indices and offsets types for split_table_batched_embeddings_ops_training.py
Differential Revision: D66919716