update pin #8677
Merged
update pin #8677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lsy323 can you plz add a description? |
lsy323
force-pushed
the
lsiyuan/pin-update
branch
from
875e8b8 to
656d589
Compare
lsy323
commented
Feb 12, 2025
ManfeiBai
reviewed
Feb 13, 2025
| Eigen::Index end = std::min(start + task_size, feature_group_count); | ||
| for (Eigen::Index i = start; i < end; ++i) { | ||
| - auto on_done = [count_down]() mutable { count_down.CountDown(); }; | ||
| + // auto on_done = [count_down]() mutable { count_down.CountDown(); }; |
There was a problem hiding this comment.
do we still want to keep this comment or add TODO for notice will bring it back in the future?
There was a problem hiding this comment.
As mentioned in PR description, once we have a newer compiler the patch can go away.
ManfeiBai
reviewed
Feb 13, 2025
| @@ -332,9 +332,6 @@ def run(self): | |||
| 'tpu': [ | |||
| f'libtpu=={_libtpu_version}', | |||
| 'tpu-info', | |||
| # This special version removes `libtpu.so` from any `libtpu-nightly` installations, | |||
| # since we have migrated to using the `libtpu.so` from the `libtpu` package. | |||
| "libtpu-nightly==0.1.dev20241010+nightly.cleanup" | |||
There was a problem hiding this comment.
cool, so we don't need libtpu-nightly wheel installed too from now?
There was a problem hiding this comment.
The date is very outdated, so I don't think we need it anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update XLA pin
This PR will unblock #8665 by introducing openxla/xla@e0f9930 to PyTorch/XLA