Add instruction for exporting inlined constant #8707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tengyifei
approved these changes
Feb 13, 2025
mikegre-google
requested changes
Feb 13, 2025
docs/source/features/stablehlo.md
Outdated
| @@ -64,6 +64,31 @@ print(stablehlo.mlir_module()) | |||
| The second to last line we used `jax.ShapedDtypeStruct` to specify the input shape. | |||
| You can also pass a numpy array here. | |||
|
|
|||
| ### Inline some weights in generated stablehlo | |||
|
|
|||
| Suppose that you want to inline some (or all) of the model's weight | |||
There was a problem hiding this comment.
Suggest:
You can inline some or all of your model's weights into the StableHLO graph as constants by exporting a separate function that calls your model.
docs/source/features/stablehlo.md
Outdated
| into the generated StableHLO graph as constant. You can accomplish it by | ||
| exporting a different function that calls your model. | ||
|
|
||
| The convention used in `jax.jit` is that, all the input of the `jit`'d python |
There was a problem hiding this comment.
Suggest: The convention used in jax.jit is all inputs to jited Python functions are exported as parameters, everything else is inlined as constants.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.