Drop python2 support #11813

Chocobo1 · 2020-01-03T03:00:47Z

I think it is better to drop py2 at next major release (v4.3.0), but sledgehammer999 can make the final decision (whether to have it in v4.2.x).

FranciscoPombal · 2020-01-03T03:07:04Z

Don't forget to change Utils::ForeignApps::PythonInfo::isSupportedVersion()

Chocobo1 · 2020-01-03T03:25:09Z

Don't forget to change Utils::ForeignApps::PythonInfo::isSupportedVersion()

Thanks, done.

sledgehammer999 · 2020-01-03T21:36:53Z

What about macOS? IIRC Apple still ships python2 only. @Kolcha can you confirm?

Kolcha · 2020-01-03T21:50:06Z

What about macOS? IIRC Apple still ships python2 only. @Kolcha can you confirm?

since macOS Catalina (10.15) Apple ships 2 Python versions: 2.7 and 3.7
python2 is used by default (python command)
any previous macOS has only python2

FranciscoPombal · 2020-01-04T14:20:09Z

What about macOS? IIRC Apple still ships python2 only. @Kolcha can you confirm?

since macOS Catalina (10.15) Apple ships 2 Python versions: 2.7 and 3.7
python2 is used by default (python command)
any previous macOS has only python2

macOS 10.9 (Mavericks) users and above can also install python from the official website, like windows users. There's also homebrew.

Kolcha · 2020-01-04T14:25:34Z

10.9 is too old, almost nothing will work on too old macOS. I used it until January 2018, and had to upgrade to 10.12 because I couldn't use most video players (which able to play my files) and even Firefox...
nowadays masOS 10.12 (Sierra) is common minimum, qBittorrent is not an exception. Moreover, when qBittorrent will use Qt 5.14, this minimum will raise to 10.13 (High Sierra)

FranciscoPombal · 2020-01-04T15:01:34Z

10.9 is too old, almost nothing will work on too old macOS. I used it until January 2018, and had to upgrade to 10.12 because I couldn't use most video players (which able to play my files) and even Firefox...
nowadays masOS 10.12 (Sierra) is common minimum, qBittorrent is not an exception. Moreover, when qBittorrent will use Qt 5.14, this minimum will raise to 10.13 (High Sierra)

Great, less backwards compatibility to worry about.

ngosang · 2020-01-04T19:51:17Z

@Chocobo1 @sledgehammer999 Here we are talking about removing all the Python code qbittorrent/search-plugins#121 Please take a look. I want to hear from you.
IMHO, if you agree with that proposal, it will be better to do it all at once instead of merging this PR. If not, users will complain 2 times, about updating Python and later about Jackett integration.

Chocobo1 · 2020-01-05T03:07:29Z

IMHO, if you agree with that proposal, it will be better to do it all at once instead of merging this PR.

I think dropping py2 is independent of the jacket integration and both are better suited targeting future qbt v4.3.0 so that users won't see the intermediate steps/pain.
I'm saying that because there is no manpower to ensure jacket integration will happen in near future.

sledgehammer999 · 2020-01-06T17:40:17Z

FYI, from the answers I got for macOS I am satisfied with dropping python2.

glassez · 2020-01-08T08:23:54Z

I think dropping py2 is independent of the jacket integration and both are better suited targeting future qbt v4.3.0

IIRC, Jacket integration means that we remove all python related stuff, isn't it?
So dropping python 2 support has any sense only if we will keep support "legacy" search feature.

Chocobo1 · 2020-01-08T09:34:55Z

So dropping python 2 support has any sense only if we will keep support "legacy" search feature.

IMO we will keep python3 support until jacket integration happens (which has no ETA currently).

glassez · 2020-01-08T09:47:33Z

we will keep python3 support until jacket integration happens (which has no ETA now).

But you want drop python 2 support in qBittorrent 4.3 that has no ETA now as well...
Or do you just want it to "blink your eyes" here for the case v4.3 is released before the Jacket support?
IMO, if there's no strong reason to keep support python 2 let's drop it now.

Chocobo1 · 2020-01-08T10:10:55Z

But you want drop python 2 support in qBittorrent 4.3 that has no ETA now as well...

As said in the very first post, sledgehammer999 can make the final decision.
The point is (also said before) dropping py2 support is independent of the jacket integration. Those are 2 separate issues and removal of all python support can happen in graduate steps/PRs.

Or do you just want it to "blink your eyes" here for the case v4.3 is released before the Jacket support?

I don't get your idiom but that is a possibility.

IMO, if there's no strong reason to keep support python 2 let's drop it now.

Obviously there is strong urge (to drop it) from the community.

Chocobo1 · 2020-01-11T10:51:10Z

PR updated. Move unrelated commits to PR #11862.

zero77 · 2020-01-11T16:12:34Z

@Chocobo1
There should be a visible warning letting users know they need to upgrade to python3.
Otherwise there will lightly be lots of issues opened, reporting bugs or asking why its not working.

Chocobo1 · 2020-01-12T04:29:01Z

There should be a visible warning letting users know they need to upgrade to python3.
Otherwise there will lightly be lots of issues opened, reporting bugs or asking why its not working.

It will stop working yes. However for Windows users it will also jump out a dialog asking to download & install python3. For other OS (linux & macOS), a log message will be recorded that python3 was not found and qbt can't really offer much in this case.

Closes qbittorrent#11811.

nazar-pc · 2020-03-04T20:55:59Z

This actually becomes a problem on Ubuntu 20.04 already. Are there blockers that prevent this from being merged?

Chocobo1 · 2020-03-05T06:20:33Z

Are there blockers that prevent this from being merged?

Still waiting for the green signal from the project maintainer (see the first post) ...

ngosang · 2020-03-05T06:41:54Z

Since there isn't any progress with Jackett I have changed my mind. I'm in favor of merging this PR.
@Chocobo1 Change the minimum version to Python 3.5.0, previous versions are deprecated.
https://devguide.python.org/devcycle/#end-of-life-branches
We should inform of Python changes in the Changelog or the website so there are less issues.

Chocobo1 · 2020-03-05T06:51:36Z

@Chocobo1 Change the minimum version to Python 3.5.0, previous versions are deprecated.

Better in another PR, feel free to open one!

ngosang · 2020-03-06T08:34:08Z

Better in another PR, feel free to open one!

I will after this one is merged.

Chocobo1 · 2020-03-07T02:20:14Z

I decided to land this in master branch, whether to have it in v4.2.x will be decided by our maintainer.

sledgehammer999 · 2020-03-22T00:14:19Z

I decided to land this in master branch, whether to have it in v4.2.x will be decided by our maintainer.

Sorry that you missed #11813 (comment)

iWrite4u · 2020-03-25T10:02:30Z

Why was my issue closed? I know qBitTorrent no longer works with Python 2.x. When I open the latest version I get the message 'upgrade your python' ... but I HAVE python3.8.1. All other apps that use python use the version of 3.8.1. on my machine. The new version of qBitTorrent is not recognising that python 3.8.1. is installed.

nazar-pc · 2020-03-25T10:38:34Z

Also Ubuntu package from PPA still depends on python, not python3 package

FranciscoPombal · 2020-03-25T10:47:41Z

Why was my issue closed? I know qBitTorrent no longer works with Python 2.x. When I open the latest version I get the message 'upgrade your python' ... but I HAVE python3.8.1. All other apps that use python use the version of 3.8.1. on my machine. The new version of qBitTorrent is not recognising that python 3.8.1. is installed.

Sorry for the misunderstanding, I have re-opened the issue.

Chocobo1 added the Search engine Issues related to the search engine/search plugins functionality label Jan 3, 2020

Chocobo1 added this to the 4.3.0 milestone Jan 3, 2020

Chocobo1 mentioned this pull request Jan 3, 2020

Drop support for Python2 qbittorrent/search-plugins#84

Closed

16 tasks

Chocobo1 force-pushed the python branch from 0befb7a to d133914 Compare January 3, 2020 03:24

Chocobo1 force-pushed the python branch from 5b4bb9a to 80641ff Compare January 11, 2020 10:49

Chocobo1 force-pushed the python branch from 80641ff to 014ddad Compare January 11, 2020 10:52

Chocobo1 force-pushed the python branch from 014ddad to 9397d11 Compare January 12, 2020 04:24

Chocobo1 requested a review from sledgehammer999 January 15, 2020 05:03

Chocobo1 force-pushed the python branch 2 times, most recently from fcbfb91 to da467e7 Compare February 8, 2020 04:30

Drop python2 support

baa13c0

Closes qbittorrent#11811.

Chocobo1 force-pushed the python branch from da467e7 to baa13c0 Compare February 8, 2020 04:37

glassez approved these changes Mar 6, 2020

View reviewed changes

Chocobo1 merged commit dc4e9e3 into qbittorrent:master Mar 7, 2020

Chocobo1 deleted the python branch March 7, 2020 02:18

ngosang mentioned this pull request Mar 7, 2020

Update minimum Python version to 3.5.0 #12137

Closed

FranciscoPombal modified the milestones: 4.3.0, 4.2.2 Mar 25, 2020

FranciscoPombal mentioned this pull request Mar 25, 2020

New Version of qbitTorrent does not recognise latest version of Python #12263

Open

FranciscoPombal mentioned this pull request Mar 25, 2020

PPA package still depends on Python >=2.7 #12267

Closed

ngosang mentioned this pull request Dec 21, 2020

Update python networking #14004

Closed

xavier2k6 mentioned this pull request Dec 27, 2020

Syntax error in setup.py (RC_1_2) arvidn/libtorrent#5783

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Drop python2 support #11813

Drop python2 support #11813

Chocobo1 commented Jan 3, 2020

FranciscoPombal commented Jan 3, 2020

Chocobo1 commented Jan 3, 2020

sledgehammer999 commented Jan 3, 2020

Kolcha commented Jan 3, 2020

FranciscoPombal commented Jan 4, 2020

Kolcha commented Jan 4, 2020 •

edited

Loading

FranciscoPombal commented Jan 4, 2020

ngosang commented Jan 4, 2020

Chocobo1 commented Jan 5, 2020 •

edited

Loading

sledgehammer999 commented Jan 6, 2020

glassez commented Jan 8, 2020

Chocobo1 commented Jan 8, 2020 •

edited

Loading

glassez commented Jan 8, 2020

Chocobo1 commented Jan 8, 2020 •

edited

Loading

Chocobo1 commented Jan 11, 2020

zero77 commented Jan 11, 2020

Chocobo1 commented Jan 12, 2020

nazar-pc commented Mar 4, 2020

Chocobo1 commented Mar 5, 2020

ngosang commented Mar 5, 2020 •

edited

Loading

Chocobo1 commented Mar 5, 2020

ngosang commented Mar 6, 2020

Chocobo1 commented Mar 7, 2020

sledgehammer999 commented Mar 22, 2020

iWrite4u commented Mar 25, 2020

nazar-pc commented Mar 25, 2020

FranciscoPombal commented Mar 25, 2020

Drop python2 support #11813

Drop python2 support #11813

Conversation

Chocobo1 commented Jan 3, 2020

FranciscoPombal commented Jan 3, 2020

Chocobo1 commented Jan 3, 2020

sledgehammer999 commented Jan 3, 2020

Kolcha commented Jan 3, 2020

FranciscoPombal commented Jan 4, 2020

Kolcha commented Jan 4, 2020 • edited Loading

FranciscoPombal commented Jan 4, 2020

ngosang commented Jan 4, 2020

Chocobo1 commented Jan 5, 2020 • edited Loading

sledgehammer999 commented Jan 6, 2020

glassez commented Jan 8, 2020

Chocobo1 commented Jan 8, 2020 • edited Loading

glassez commented Jan 8, 2020

Chocobo1 commented Jan 8, 2020 • edited Loading

Chocobo1 commented Jan 11, 2020

zero77 commented Jan 11, 2020

Chocobo1 commented Jan 12, 2020

nazar-pc commented Mar 4, 2020

Chocobo1 commented Mar 5, 2020

ngosang commented Mar 5, 2020 • edited Loading

Chocobo1 commented Mar 5, 2020

ngosang commented Mar 6, 2020

Chocobo1 commented Mar 7, 2020

sledgehammer999 commented Mar 22, 2020

iWrite4u commented Mar 25, 2020

nazar-pc commented Mar 25, 2020

FranciscoPombal commented Mar 25, 2020

Kolcha commented Jan 4, 2020 •

edited

Loading

Chocobo1 commented Jan 5, 2020 •

edited

Loading

Chocobo1 commented Jan 8, 2020 •

edited

Loading

Chocobo1 commented Jan 8, 2020 •

edited

Loading

ngosang commented Mar 5, 2020 •

edited

Loading