Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop I2P support with libtorrent 1.2 #19207

Merged
merged 1 commit into from
Jun 23, 2023
Merged

Conversation

glassez
Copy link
Member

@glassez glassez commented Jun 20, 2023

libtorrent 1.2 does not contain a lot of I2P related fixes made recently, and I2P is almost completely unusable there (according to the feedbacks of the users involved).

Also fixes build when libtorrent is compiled with I2P support disabled.
Closes #19152.

@glassez glassez added GUI GUI-related issues/changes Core labels Jun 20, 2023
@glassez glassez added this to the 4.6.0 milestone Jun 20, 2023
@glassez glassez requested a review from a team June 20, 2023 15:24
@glassez
Copy link
Member Author

glassez commented Jun 20, 2023

@Vort, ping!

@glassez glassez marked this pull request as draft June 20, 2023 15:32
@xavier2k6
Copy link
Member

@glassez I haven't been able to test I2P myself but there are other issues with I2P support that need to be handled as well (when possible)....quick summary -> #19066 (comment)

@Vort
Copy link
Contributor

Vort commented Jun 20, 2023

I did not tested I2P support with 1.2 and do not know what users think about it, but I plan to check 2.0 support for regressions once build is fixed.

@Pentaphon
Copy link

Pentaphon commented Jun 20, 2023

libtorrent 1.2 does not contain a lot of I2P related fixes made recently, and I2P is almost completely unusable there (according to the feedbacks of the users involved).

As long as there continues to be libtorrent 1.2 qBit builds (since arvid is still pushing out updates to 1.2.x) then it should be fine. People should be notified that they need to use 2.0.x builds to get i2p support, which admittedly, not a lot of people care about yet. I don't think most people even know what i2p even is.

libtorrent 1.2 builds should remain default until 2.x becomes as stable as 1.x.

@glassez
Copy link
Member Author

glassez commented Jun 21, 2023

I did not tested I2P support with 1.2 and do not know what users think about it

As per #19066:

In, the realease, 4.6.0alpha1 (lt12 qt6) I2P does not work at all - neither via I2PD nor via JAVA I2P

@Vort
Copy link
Contributor

Vort commented Jun 21, 2023

I checked 2.0 build from this branch: I2P download and upload works ok.

@glassez glassez marked this pull request as ready for review June 21, 2023 07:14
@glassez
Copy link
Member Author

glassez commented Jun 21, 2023

there are other issues with I2P support that need to be handled as well (when possible)....quick summary -> #19066 (comment)

I am aware of this. However, it is not a priority for me, although it is on my to-do list. I'll come back to it from time to time.

@glassez glassez merged commit 3b948b0 into qbittorrent:master Jun 23, 2023
@glassez glassez deleted the i2p branch June 23, 2023 13:24
@glassez glassez added Hotfix Fix some bug(s) introduced by recently merged commit(s) and removed GUI GUI-related issues/changes Core labels Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hotfix Fix some bug(s) introduced by recently merged commit(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error: ‘const struct libtorrent::peer_info’ has no member named ‘i2p_destination’
4 participants