-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dark theme for WebUI #19901
Add dark theme for WebUI #19901
Conversation
Adaptive webui 19844
Adaptive webui private 19844
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also you might want to run the CI checks locally so you don't need to wait for our CI.
You'll need to install nodejs & npm: https://nodejs.org/en/download/
After installation, open a command line at src/webui/www directory and run npm install
.
Then you can run the checks: npm run lint && npm run format
Sorry i don't have any suggestions about colors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@d47081
This PR has no other task pending and is ready to merge, right?
In addition to my other comments, I intend to make the following changes (all by myself). I hope you'll be ok with it since it will apply on your git branch:
- Move
vanillaSelectBox.css
out oflib
directory - Revert changes to
public
folder and rely on<meta name="color-scheme" content="dark light">
instead.
If there are no objections, I'll apply the changes in the next few days and afterwards approve/merge it. Please leave this PR branch as is, I'll handle the rest.
I'm using this implementation about month in dark mode and found no problems there. @thalieht said there is low contrast, but on my screen (iMac) - it's enough for me. Maybe it depend from monitor settings. I'm also not designer, just grab previous blue/orange palette and adapted it (just reduced saturation to make not such toxic for eyes) @Chocobo1 okay, just let me know if something needed from my side |
67b41ba
to
bbb51e2
Compare
as we now customize it and not just following upstream.
bbb51e2
to
8a7a649
Compare
@qbittorrent/bug-handlers
Now the login page (mostly) uses color palette from the browser. IMO this page doesn't need to be heavily customized unlike the main window page (after login). |
@d47081 |
Can it be used to design a dark theme for the native app? |
@Chocobo1 with pleasure!
Web UI is different component and not related with desktop theme |
It is environment-dependent, plus the skin at your screen looks cached |
?? Not following you @d47081
Should not be, have reloaded with ctrl + shift + r and ctrl + f5 so it should be the fresh one. |
Nice idea with dark theme, but why there so huge paddings? Default padding was better. Also progressbar can be fullheight. All together it looks weird. |
Thanks for the merge, I like the official UI so I never switched to alternative Web UIs, |
Created common branch for
#19888
#19847
Feature request:
#19844
All next contribution will be here:
https://github.com/d47081/qBittorrent/tree/adaptive-webui