Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong time stamp values in WebAPI #20239

Merged
merged 4 commits into from
Jan 8, 2024

Conversation

Chocobo1
Copy link
Member

@Chocobo1 Chocobo1 commented Jan 6, 2024

  • Fix wrong time stamp values in WebAPI
    The wrong values are observed when encountered an invalid QDateTime data.
  • Leave the fields empty when value is invalid
    This follows GUI behavior.
  • Use initialization form for variable
  • Provide safe helper for converting to 'seconds since epoch'

ps. I intend to use 'rebase and merge' strategy.

@Chocobo1 Chocobo1 added WebUI WebUI-related issues/changes WebAPI WebAPI-related issues/changes labels Jan 6, 2024
@Chocobo1 Chocobo1 added this to the 5.0 milestone Jan 6, 2024
@Chocobo1 Chocobo1 requested a review from a team January 6, 2024 07:24
The wrong values are observed when encountered an invalid QDateTime data.
@Chocobo1 Chocobo1 force-pushed the creationDate branch 3 times, most recently from c8fee01 to a906b8c Compare January 6, 2024 10:25
@Chocobo1 Chocobo1 force-pushed the creationDate branch 2 times, most recently from da6187c to 953c904 Compare January 6, 2024 10:42
@Chocobo1 Chocobo1 merged commit ad22237 into qbittorrent:master Jan 8, 2024
13 checks passed
@Chocobo1 Chocobo1 deleted the creationDate branch January 8, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WebAPI WebAPI-related issues/changes WebUI WebUI-related issues/changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants