-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the color of the stop status text and icon #21749
base: master
Are you sure you want to change the base?
Conversation
@stalkerok I have to disagree with the text being orange. A lot of people will complain because:
Personally, I think you should follow what I outlined at #21448 as people seem to be responding well to it. We should also have a discussion with the community about having a larger default color change as you seem to be willing to make default color changes. |
I don't think we should change the color in the transfer list or the sidebar. Especially not to orange. |
I am fine with the text color changing to orange when a torrent is stalled so a user can see it more easily when it stalls. Ideally, we should have a better stop icon, but somebody needs to create one. |
Are there any pitfalls to using orange? |
This PR is stale because it has been 60 days with no activity. This PR will be automatically closed within 7 days if there is no further activity. |
How about #e16f24 and #f0883e for light and dark mode? Colors taken from https://primer.style/primitives/storybook/ Or #bc4c00 and #db6d28? These colors are used in the log for warning messages. |
I think the current colors are fine. I think most people are annoyed by the current text colors and I came up with what I think is a good text color scheme for the transfer list here: #21448 The text should only turn orange if a torrent becomes stalled, Otherwise, the transfer list should mostly be black or white when they are just sitting there waiting for something to happen. |
Closes #21734