-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve CI scripts #22351
Improve CI scripts #22351
Conversation
It seems ~500MB is enough to cache all the build artifacts but we still make it a bit larger to avoid thrashing.
Now vcpkg caches b2 tool. Boost doesn't need the exact b2 version to generate the cmake files.
@Chocobo1 Just thought of something If microsoft/vcpkg#42678 gets merged, then that may be problematic for RC_1_2 libtorrent builds due to the deprecations contained in Boost 1.87.0 I've tried to limit macOS in libtorrent RC_1_2 to Boost 1.85.0 but More context on Boost issue: arvidn/libtorrent#7875 Perhaps a stand-alone release can be used from https://github.com/bfgroup/b2/releases ? |
Don't worry, it won't affect us. This is like using a newer cmake.exe to run an older CMakeLists.txt which should be compatible.
The PR is different to qbt CI so we won't face the same problem. You could try to limit boost-build to 1.85 in that PR.
It will probably never be resolved IMO. Despite the code changes there might be ABI compatibility concerns that comes along.
I checked their releases and they didn't provide a pre-built b2.exe which we required. |
I wonder why we need b2 at all. After all, we use header-only Boost libraries. |
It is required to generate cmake files. |
As far as I understood this, the header files are in the Here is me building with no header generation qbittorrent desktop and nox on Debian based using latest cmake with no issue. None of my builds require me to use b2 unless 1: i'm using b2 to build libtorrent or 2: i cloned boost from github. As far as I can see you do neither of those and could just link to the boost folder. Unless i'm missing something here as to why header are generated. |
|
I build with this https://github.com/userdocs/cmake-crossbuild/releases/tag/3.31.5_1.12.1 If it was removed in 3.30 how can it be the same issue? |
So I removed the It builds ok https://github.com/userdocs/qbittorrent-crossbuild/actions/runs/13640403413 This would be using policy |
It seems ~500MB is enough to cache all the build artifacts but we still make it a bit larger to avoid thrashing.
Now vcpkg caches b2 tool. Boost doesn't need the exact b2 version to generate the cmake files.