Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust minimum alternative rate limits to zero #9214

Closed

Conversation

FurkanKambay
Copy link

@FurkanKambay FurkanKambay commented Jul 20, 2018

I don't know if there was a reason for not having 0 as an option (for 0 B/s, not unlimited). If it's allowed, there you go.
edit: ignore this. didn't realize that 0 was used by libtorrent as unlimited. can't achieve this by allowing 0.

@sledgehammer999
Copy link
Member

upload_rate_limit and download_rate_limit sets the session-global limits of upload and download rate limits, in bytes per second. By default peers on the local network are not rate limited.

A value of 0 means unlimited.

The "unlimited" setting is controlled by the checkbox that exists in the side of the spinbox.

@FurkanKambay
Copy link
Author

FurkanKambay commented Jul 21, 2018

@sledgehammer999 sorry, should've mentioned this. I meant 0 to be off, not unlimited.
Can we use -1 for 0B/s since it's signed int?

edit: Sorry, just realized it's a libtorrent thing. Also, I admit that I opened the PR immaturely. Anyway, I'd like to ask, if turning off were implemented, would it be accepted?

@FurkanKambay FurkanKambay deleted the adjust-minimum-speed branch July 21, 2018 00:51
@sledgehammer999
Copy link
Member

Setting speed to 0 B/s effectively means stopping transfer. So the correct method is to either stop the respective torrent or stop the entire session ( <--- a libtorrent::session )

@FurkanKambay
Copy link
Author

@sledgehammer999 Yeah, stopping the current session is probably good. I won't work on this separately since it's going to be included in #9203 if I can finish it. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants