Relax the handshake count check in handshakeloss test #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In doing interop testing, its been observed that, occasionally, if the test drops a sufficient number of handshake frames, a client may transiently fail for any number of reasons (running up against the max idle timeout for instance). In this event it may be handled by the application by simply retrying the request. This however causes the interop test to fail, as the test checks for the presence of exactly 50 handshakes, and a retry triggers handshakes above that count. It would seem prudent to allow the test to only check for a minimum number of handshakes, but allow for the possibility of more for clients that behave in this manner. Alter the handshakeloss test to only fail if there are less than 50 handshakes present.
|
@andrewkdinh for reference |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In doing interop testing, its been observed that, occasionally, if the test drops a sufficient number of handshake frames, a client may transiently fail for any number of reasons (running up against the max idle timeout for instance). In this event it may be handled by the application by simply retrying the request. This however causes the interop test to fail, as the test checks for the presence of exactly 50 handshakes, and a retry triggers handshakes above that count. It would seem prudent to allow the test to only check for a minimum number of handshakes, but allow for the possibility of more for clients that behave in this manner.
Alter the handshakeloss test to only fail if there are less than 50 handshakes present.