Complete Hook example #4298
Complete Hook example #4298
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Hi! Looks like you've reached your API usage limit. You can increase it from your account settings page here: app.greptile.com/settings/billing/code-review
💡 (3/5) Reply to the bot's comments like "Can you suggest a fix for this @greptileai?" or ask follow-up questions!
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
api/python/quilt3/hooks.py:54
- There is an unnecessary blank line at the end of the code block which should be removed.
old_hook = set_build_s3_client_hook(hook)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4298 +/- ##
========================================
Coverage 39.11% 39.11%
========================================
Files 783 783
Lines 34737 34737
Branches 5308 5517 +209
========================================
Hits 13586 13586
+ Misses 20608 19970 -638
- Partials 543 1181 +638
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
api/python/quilt3/hooks.py
Outdated
| @@ -30,7 +30,10 @@ def set_build_s3_client_hook(hook: T.Optional[BuildClientHook]) -> T.Optional[Bu | |||
|
|
|||
| Example for overriding `ServerSideEncryption` parameter for certain S3 operations: | |||
|
|
|||
| <!--pytest.mark.skip--> | |||
There was a problem hiding this comment.
maybe this should be fixed instead of ignored?
There was a problem hiding this comment.
Sure. How? The main point of the example is to show how to correctly import the API:
from quilt3.hooks import set_build_s3_client_hook
But that is what's breaking the test:
No module named 'quilt3.hooks'
How could I work around that?
There was a problem hiding this comment.
But that is what's breaking the test:
No module named 'quilt3.hooks'
How could I work around that?
test with version of quilt3 which has it?
There was a problem hiding this comment.
Sorry I'm being dense. How do I do that? Adding this to the testdocs CI doesn't seem to help:
python -m pip install api/python
There was a problem hiding this comment.
maybe because poetry install re-installs older version?
Show import and invocation
(I was confused, so I figured we should extend it so nobody else is).