Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabulator missing column docs #4302

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Conversation

drernie
Copy link
Member

@drernie drernie commented Jan 28, 2025

Description

TODO

  • Documentation
    • run optipng on any new PNGs
    • Markdown somewhere in docs/**/*.md that explains the feature to end users (said .md files should be linked from SUMMARY.md so they appear on https://docs.quiltdata.com)

@drernie drernie marked this pull request as draft January 28, 2025 23:44
@drernie drernie self-assigned this Jan 28, 2025
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Updated Tabulator documentation to clarify version requirements and document new features in v1.58, including support for missing columns and the $issue column functionality.

  • Clarified platform version requirement to v1.55.0+ (changed from "stack version")
  • Added documentation for new $issue column in v1.58 for tracking schema inconsistencies
  • Updated schema consistency requirements to explain v1.58's missing columns support
  • Documented that named capture groups can be extracted from both logical_key and package_name regex patterns

💡 (5/5) You can turn off certain types of comments like style here!

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.11%. Comparing base (61b45e8) to head (2defa26).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4302   +/-   ##
=======================================
  Coverage   39.11%   39.11%           
=======================================
  Files         783      783           
  Lines       34737    34737           
  Branches     5517     5517           
=======================================
  Hits        13586    13586           
  Misses      19970    19970           
  Partials     1181     1181           
Flag Coverage Δ
api-python 91.39% <ø> (ø)
catalog 18.12% <ø> (ø)
lambda 91.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant