Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor #33

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Refactor #33

wants to merge 6 commits into from

Conversation

nixin72
Copy link
Member

@nixin72 nixin72 commented Feb 2, 2025

Did some refactoring:

  • Moved code into src folder
  • Removed use of external bat/bash files
  • Reduced number of network requests required
  • Simplified code

- Moved code into src folder
- Removed use of external bat/bash files
- Reduced number of network requests required
- Simplified code
@nixin72 nixin72 self-assigned this Feb 2, 2025
@nixin72
Copy link
Member Author

nixin72 commented Feb 2, 2025

@spdegabrielle This is the first time I've touched Racket in over 2 years - any chance I could get a review on this? 😅

@spdegabrielle
Copy link
Member

Happy to review.
I'll be able to have a look tomorrow evening.

@spdegabrielle spdegabrielle self-requested a review February 2, 2025 21:46
@spdegabrielle
Copy link
Member

so I removed the old versions from my install, and did a fresh raco pkg install of the refactor branch
ran raco new
not sure what is going on here.

image
Last login: Sun Feb  2 21:47:14 on ttys000
stephendegabrielle@MacBookPro test-raco-new % raco new    
instantiate: unknown module
  module name: (submod 'raco-new/main.rkt[840] main)
  context...:
   /Applications/Racket v8.16.0.1/collects/raco/raco.rkt:41:0
   body of "/Applications/Racket v8.16.0.1/collects/raco/raco.rkt"
   body of "/Applications/Racket v8.16.0.1/collects/raco/main.rkt"
stephendegabrielle@MacBookPro test-raco-new % 

@nixin72
Copy link
Member Author

nixin72 commented Feb 2, 2025

Ahh, my bad - I didn't test installing the package, was just running from the CLI. Will work on adding CI for testing down the road...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants