Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Use abi-compatible directory for loading plugins #20545

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

trufae
Copy link
Collaborator

@trufae trufae commented Aug 2, 2022

  • Mark this if you consider it ready to merge
  • I've added tests (optional)
  • I wrote some lines in the book (optional)

Description

@trufae
Copy link
Collaborator Author

trufae commented Dec 3, 2024

@MewtR thoughs on this? can you finish this PR and merge it?

@MewtR
Copy link
Contributor

MewtR commented Dec 7, 2024

I'll take a look

@MewtR
Copy link
Contributor

MewtR commented Dec 8, 2024

Is there any reason why the abi version is Major.Minor.x as opposed to just Major.Minor like it's already defined in config-user.mk.acr? This isn't a huge deal and can be easily changed but I'm just wondering

@trufae
Copy link
Collaborator Author

trufae commented Dec 8, 2024

Irs about clarifying the version implies 3 digits. Also it should take into account that .9 is not abi stable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants