-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update preconfigure.bat #22842
Update preconfigure.bat #22842
Conversation
In previous code, if a user didn't provide any argument with the command then x86 will be selected as Host by default which is kind of Flawed. This change will detect the Host system on its and will allow the user to select the target system
Now that you are messing with the windows build scripts, would you like to take a look at this ticket to do the windows-arm64 builds in the CI so we can have those artifacts in the next release? #22612 thanks! |
Will definitely give it a look. |
I think the last update to preconfigure.bat should have solved this issue, as I ran |
If you carefully observe the old code:
If the user does not specify an architecture as an argument while running Also, if you provide the argument arm64 while running preconfigure.bat, the host architecture x86 will be selected, even if you prefer or your architecture is The new code will avoid all this hassle and give users the ability to select the required platforms. |
If a user specifies an architecture as an argument while running The host architecture is detected by the script using |
@mriamnobody i think the blocker was that meson required a config file for crosscompiling, here's the latest attempt from @prodrigestivill to get this to work prodrigestivill@1e174f9 you can continue your patch from there. i'll find some time later today to try in local, but afaik it's "just" a "ci issue" |
Also is usefull this commit: Not sure why without this, the script doesn't detect the vscode. I don't have a windows environment to test it. |
In previous code, if a user didn't provide any argument with the command then x86 will be selected as Host by default which is kind of Flawed.
This change will detect the Host system on its and will allow the user to select the target system
Description