-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for new EVM opcodes #23878
base: master
Are you sure you want to change the base?
Conversation
if you think it's worth backporting (i dont think so) you can do it. i would opt for wrapping those cases with an ifdef depending on the version of capstone linked to radare2. I think it's fine to assume that r2 wont be able to use those instructions if you are linking to capstone 4 or 5 because distros need to update those packages when cs6 is out (dunno when will this happen). |
@trufae Thanks for the heads up! I'll plan to add the required patches once capstone-engine/capstone#2602 lands. UPDATE/EDIT: I was thinking it's required to make evm.c/evm.h compatible with the arch.evm plugin(capstone part). If it doesn't matter, then |
I'll pick up this as the upstream PR is merged. |
c1bb9a2
to
8d44119
Compare
@trufae I've addressed the previous feedback and this is now ready for review. Thank you for your time. |
I'll fix the lint errors later this week. |
Please rebase the pr too. Thanks! |
This is followed by: capstone-engine/capstone#2602
The repo URL is temperorily changed to my fork,use the following to build with the new EVM support:Description
Question
It is required to back-port these changes to capstone v4 and v5 using patch files?