Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ol-stac migration #531 #535

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

ol-stac migration #531 #535

wants to merge 11 commits into from

Conversation

m-mohr
Copy link
Collaborator

@m-mohr m-mohr commented Jan 14, 2025

Implements/Fixes

Open issues:

Potential features to be considered:

Breaking changes:

  • Removed maxPreviewsOnMap
  • buildTileUrlTemplate default to null now. The function has a different signature now, an Asset object (see stac-js) is passed as only argument. No other parameters are passen. To get the absolute url for the URL constuction, use asset.getAbsoluteUrl()
  • basemaps.config.js has a new format. Multiple basemaps per planet can be provided. The default behaviour of configureBasemap has changed, including a removal of the map parameter.

@m-mohr m-mohr added the mapping label Jan 14, 2025
@m-mohr m-mohr added this to the 3.4.0 milestone Jan 14, 2025
@m-mohr m-mohr force-pushed the ol-stac branch 2 times, most recently from 13d5ae5 to bcbbf3a Compare January 14, 2025 23:38
@luipir
Copy link

luipir commented Jan 16, 2025

great :)

@luipir
Copy link

luipir commented Jan 20, 2025

@m-mohr FYI this branch allow correctly stream from a local titiler, but not able to show any collection footprint served by eoAPI pgstac compose (removing stac-browser). Footprint is shown only for Items.

@m-mohr
Copy link
Collaborator Author

m-mohr commented Jan 25, 2025

@luipir Your problem should be fixed.

Generally, I've tried to better document above what known issues exist, all other functionality should be back and working. You can start tests now.

@luipir
Copy link

luipir commented Jan 28, 2025

This has been fixed, it shows now where the mouse click happened. It can't directly attach to the feature anymore as we support selecting multiple features now. Beforehand you could only select the topmost is multiple features were stacked over each other.

confirmed that it works now :)

Once the next ol-stac release is released, STAC Browser will also highlight the selected features in red again and have a bit of a hit tolerance to click smaller geometries easier.

:)

Thanks for the report @luipir .

thank you for the bug fix and new features :)

@luipir
Copy link

luipir commented Feb 1, 2025

FYI, not clear to me if this is a regression or the issue was there before but I can't draw BBOX to set up spatial extent to prepare a spatial query to the catalog.
There is a trigger of many errors and no way to draw a polygon. BTW the extent of the current show map is used to setup the spatial query
Screenshot from 2025-02-01 12-42-17

@m-mohr
Copy link
Collaborator Author

m-mohr commented Feb 1, 2025

@luipir You should be able to create a bbox regardless of the error. Please be aware that it was not a "drawing" mechanism (click & drag) to create the initial bbox, instead it was a single click and then you can adjust from there. I just implemented shift click & drag as well to create a bounding box.

Nevertheless, the error has also been fixed. Thanks.

@luipir
Copy link

luipir commented Feb 3, 2025

FYI some other glitches that are not present in main.

  1. The error appear ONLY after the spatial query is executed
  2. there is not a zoom to the BBOX of the union of bboxes of the query results and the main map is shown at whole earth level.
  • IMHO a good feature in the search box map is to fit to the catalog bbox as starting point. BTW it is a feature not a bug.
    Screenshot from 2025-02-03 10-17-00

p.s. sorry if I can't help in fixing directly the code, I'm not so expert in vue framework to be more effective helping you :/

@m-mohr
Copy link
Collaborator Author

m-mohr commented Feb 3, 2025

@luipir I think both issues should be fixed/implemented now.

@luipir
Copy link

luipir commented Feb 3, 2025

@luipir I think both issues should be fixed/implemented now.

right has been fixed, but still having select item issue.
Screenshot from 2025-02-03 13-04-34

@luipir
Copy link

luipir commented Feb 3, 2025

FYI is it already an main issue that after dig into an item selected via search gui , than "back" start from a brand new query without remind what was the previous search setup?

@m-mohr
Copy link
Collaborator Author

m-mohr commented Feb 3, 2025

@luipir I can't reproduce the selection issue, unfortunately. Are your dependencies up to date? Can you link me to an example?

It's indeed a bit cumbersome that the Search doesn't remember the search query, but that's a different issue and tracked via #393. It's major effort to improve this. I recommend opening items in a new tab for now.

@luipir
Copy link

luipir commented Feb 3, 2025

It's indeed a bit cumbersome that the Search doesn't remember the search query, but that's a different issue and tracked via #393. It's major effort to improve this. I recommend opening items in a new tab for now.

ok, no problem

@luipir
Copy link

luipir commented Feb 3, 2025

@luipir I can't reproduce the selection issue, unfortunately. Are your dependencies up to date?

checking with a clean install

Can you link me to an example?

I already shared times privately a set of json and link to real images.

@m-mohr
Copy link
Collaborator Author

m-mohr commented Feb 3, 2025

I already shared times privately a set of json and link to real images.

Yes, but only static files. Search doesn't work on static files and it takes too much time to set up a whole new fastapi instance just to test this, sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants