added gh cli to citestwheel #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajschmidt8
approved these changes
Feb 13, 2025
|
This PR is to support work on https://github.com/rapidsai/ops/issues/2982 |
bdice
reviewed
Feb 18, 2025
| @@ -131,6 +131,17 @@ ENV PATH="/pyenv/versions/${PYTHON_VER}/bin/:$PATH" | |||
| COPY --from=aws-cli /usr/local/aws-cli/ /usr/local/aws-cli/ | |||
| COPY --from=aws-cli /usr/local/bin/ /usr/local/bin/ | |||
|
|
|||
| # Download and install GH CLI tool | |||
| ARG GH_CLI_VER=notset | |||
| ARG CPU_ARCH=notset | |||
There was a problem hiding this comment.
@VenkateshJaya Could you file a follow-up to move this ARG CPU_ARCH=notset higher up in the file, to match what we do in ci-wheel? See
Line 13 in e235fac
Also, could we move this block above # Install pyenv? That would make the ordering of the citestwheel commands more similar to those in ci-wheel.
There was a problem hiding this comment.
I can file a PR to make these changes if someone else would approve it.
There was a problem hiding this comment.
I'll do the changes @bdice and open up a new PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds GitHub CLI (gh cli) for the
citestwheel