Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting the appProtocol on the serve Service #2347

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

JacobSMoller
Copy link

@JacobSMoller JacobSMoller commented Sep 2, 2024

When using gRPC and istio gateways to get proper protocol selection we need to be able either change the name of the port which it seems there is an opinion that it should be called serve or we need to be able to set appProtocol https://istio.io/latest/docs/ops/configuration/traffic-management/protocol-selection/ to keep the naming consistent I propose opening up setting the appProtocl on the serveService.

@JacobSMoller
Copy link
Author

@kodwanis as this is building on #1117 that you worked on maybe you can help me with what I should add in terms of testing.

I can't really figure out if the test you already have is sufficient or if im missing something obvious in terms of getting this to work with gRPC

@kevin85421 kevin85421 mentioned this pull request Sep 3, 2024
2 tasks
@kevin85421 kevin85421 self-assigned this Oct 5, 2024
@kevin85421
Copy link
Member

@JacobSMoller would you mind providing details about how do you manually test this PR (and the YAML you use)? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants