[Feature][kubectl-plugin] Add all and worker node type to kubectl ray log
#2442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chiayi
changed the title
all and worker node type to kubectl ray logall and worker node type to kubectl ray log
chiayi
force-pushed
the
kubectl-plugin
branch
from
d49d149
to
8c526e3
Compare
MortalHappiness
requested changes
Oct 15, 2024
chiayi
force-pushed
the
kubectl-plugin
branch
4 times, most recently
from
6380f38
to
03f0edc
Compare
andrewsykim
reviewed
Oct 16, 2024
|
The "Downloading file" logs seem pretty noisy. Can we only log it once per node? |
chiayi
force-pushed
the
kubectl-plugin
branch
from
03f0edc
to
3c314b5
Compare
chiayi
force-pushed
the
kubectl-plugin
branch
from
3c314b5
to
f027d0d
Compare
andrewsykim
reviewed
Oct 18, 2024
| } | ||
|
|
||
| fmt.Fprintf(options.ioStreams.Out, "Downloading file for Ray Node %s\n", rayNode.Name) |
There was a problem hiding this comment.
Downloading logs for Ray Node
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR adds the node type "worker" and "all" to
kubectl ray logWorker logs:
All RayCluster logs:
Related issue number
Part of #2419
Checks