Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Fix windows build for pipe logger #49780

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[core] Fix windows build for pipe logger #49780

wants to merge 1 commit into from

Conversation

dentiny
Copy link
Contributor

@dentiny dentiny commented Jan 11, 2025

This PR does two things:

  • Finish a TODO for using compat macro to represent windows HANDLE type and unix file descriptor
  • Fix compilation on windows

@dentiny dentiny added the go add ONLY when ready to merge, run all tests label Jan 11, 2025
@dentiny dentiny requested review from jjyao and rynewang January 11, 2025 09:17
@dentiny dentiny force-pushed the hjiang/fix-windows-build branch from 1aa8bb3 to 54bd440 Compare January 11, 2025 11:51
@dentiny
fix windows build
ebcf2fa 
Signed-off-by: dentiny <[email protected]>
@dentiny dentiny force-pushed the hjiang/fix-windows-build branch from 54bd440 to ebcf2fa Compare January 11, 2025 11:52
@dentiny dentiny requested a review from aslonnie January 11, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjyao jjyao Awaiting requested review from jjyao

@rynewang rynewang Awaiting requested review from rynewang

@aslonnie aslonnie Awaiting requested review from aslonnie

At least 1 approving review is required to merge this pull request.

Assignees

@jjyao jjyao

@rynewang rynewang

@aslonnie aslonnie

Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dentiny @jjyao @rynewang @aslonnie