-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sniffer extension #16587
base: main
Are you sure you want to change the base?
Add sniffer extension #16587
Conversation
- remove script.sh: delete the resilient network device tracking script - initialize project with basic configuration and network tracking functionality
Congratulations on your new Raycast extension! 🚀 You can expect an initial review within five business days. Once the PR is approved and merged, the extension will be available on our Store. |
…tures, installation, and usage instructions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi 👋
Thanks for your contribution 💪
I have now tested your extension, and I have some feedback ready for you:
- I'm not sure what this does and how it works, for me I just see this
-
It looks like I don't have the bridge?
arp: interface bridge100 does not exist
-
There are similar extensions in the store, maybe after getting some more context it might make sense 😊
I'm looking forward to testing this extension again 🔥
Request a new review when you are ready. Feel free to contact me here or at Slack if you have any questions.
- update package-lock.json: remove lockfileVersion for compatibility - refactor service.tsx: streamline device fetching and enhance bridge interface detection
Thank you for your feedback! I’ve made several changes to the code. In the new version, instead of using hardcoded values, the extension now searches for interfaces that include ap1 as a member to identify the one with the hotspot enabled. This extension works under the following conditions:
|
- Fix code style issues in sniffer/src/hotspot.tsx using Prettier - update package-lock.json: remove lockfileVersion for compatibility - refactor service.tsx: streamline device fetching and enhance bridge interface detection
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like some nice updates
- The extension icon is not working well in both appearances; could you look into this? If you struggle to do so, then you can use our generator
- fix: update icon filename in package.json to use underscore - Fix code style issues in sniffer/src/hotspot.tsx using Prettier
I have updated the icon in the extension using raycast builder tool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Could you remove extension-icon.png
Should we unify the naming better 🙂
extensions/sniffer/package.json
Outdated
"commands": [ | ||
{ | ||
"name": "hotspot", | ||
"title": "Sniffer", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"title": "Sniffer", | |
"title": "Show Connected Hotspots", | |
"subtitle": "Sniffer", |
Co-authored-by: Per Nielsen Tikær <[email protected]>
Description
Screencast
sniffer.mov
Checklist
npm run build
and tested this distribution build in Raycastassets
folder are used by the extension itselfREADME
are placed outside of themetadata
folder