Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sniffer extension #16587

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Add sniffer extension #16587

wants to merge 9 commits into from

Conversation

Amr-Shams
Copy link

@Amr-Shams Amr-Shams commented Jan 24, 2025

Description

Screencast

sniffer.mov

Checklist

- remove script.sh: delete the resilient network device tracking script
- initialize project with basic configuration and network tracking functionality
@raycastbot raycastbot added the new extension Label for PRs with new extensions label Jan 24, 2025
@raycastbot
Copy link
Collaborator

Congratulations on your new Raycast extension! 🚀

You can expect an initial review within five business days.

Once the PR is approved and merged, the extension will be available on our Store.

@pernielsentikaer pernielsentikaer self-assigned this Jan 29, 2025
Copy link
Collaborator

@pernielsentikaer pernielsentikaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi 👋

Thanks for your contribution 💪

I have now tested your extension, and I have some feedback ready for you:

  • I'm not sure what this does and how it works, for me I just see this

Raycast 2025-01-29 at 12 45 03

  • It looks like I don't have the bridge? arp: interface bridge100 does not exist

  • There are similar extensions in the store, maybe after getting some more context it might make sense 😊

I'm looking forward to testing this extension again 🔥

Request a new review when you are ready. Feel free to contact me here or at Slack if you have any questions.

- update package-lock.json: remove lockfileVersion for compatibility
- refactor service.tsx: streamline device fetching and enhance bridge interface detection
@Amr-Shams
Copy link
Author

Thank you for your feedback! I’ve made several changes to the code. In the new version, instead of using hardcoded values, the extension now searches for interfaces that include ap1 as a member to identify the one with the hotspot enabled.

This extension works under the following conditions:

  • macOS is being used.
  • The hotspot is enabled and configured correctly.
  • (Currently unknown) assuming any value with ap1 as a member of the interface considered to be a hotspot interface

- Fix code style issues in sniffer/src/hotspot.tsx using Prettier
- update package-lock.json: remove lockfileVersion for compatibility
- refactor service.tsx: streamline device fetching and enhance bridge interface detection
Copy link
Collaborator

@pernielsentikaer pernielsentikaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like some nice updates

  • The extension icon is not working well in both appearances; could you look into this? If you struggle to do so, then you can use our generator

- fix: update icon filename in package.json to use underscore
- Fix code style issues in sniffer/src/hotspot.tsx using Prettier
@Amr-Shams
Copy link
Author

I have updated the icon in the extension using raycast builder tool

Copy link
Collaborator

@pernielsentikaer pernielsentikaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Could you remove extension-icon.png

Should we unify the naming better 🙂

extensions/sniffer/CHANGELOG.md Show resolved Hide resolved
extensions/sniffer/README.md Outdated Show resolved Hide resolved
extensions/sniffer/package.json Outdated Show resolved Hide resolved
"commands": [
{
"name": "hotspot",
"title": "Sniffer",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"title": "Sniffer",
"title": "Show Connected Hotspots",
"subtitle": "Sniffer",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new extension Label for PRs with new extensions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants