Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Safari] Disable Pinyin by default #16802

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Ernest0-Production
Copy link
Contributor

Description

Resolves #16717

Checklist

@raycastbot raycastbot added extension fix / improvement Label for PRs with extension's fix improvements extension: safari Issues related to the safari extension labels Feb 3, 2025
@raycastbot
Copy link
Collaborator

raycastbot commented Feb 3, 2025

Thank you for your contribution! 🎉

🔔 @loris @thomaspaulmann @SKaplanOfficial @axsuul @iwex @xilopaint @ChangeHow @ridemountainpig @1weiho you might want to have a look.

You can use this guide to learn how to check out the Pull Request locally in order to test it.

You can expect an initial review within five business days.

@ChangeHow
Copy link
Contributor

LGTM. The pinyin package is quite large, which can significantly increase load times. I believe it would be more efficient to load the plugin via settings. Thank you for the improvement!❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extension fix / improvement Label for PRs with extension's fix improvements extension: safari Issues related to the safari extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Safari] Add local cache for bookmarks
3 participants