Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Search npm] Fix URL parsing issue #16824

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

LitoMore
Copy link
Contributor

@LitoMore LitoMore commented Feb 4, 2025

Description

Fixes #16818

  • Fix URL parsing issue

The get-url-parse's dependency parse-url doesn't support some protocols like git+https. So we force replaced the protocol to https: as a workaround.

I also reported this issue to IonicaBizau/parse-url#86. We can remove the workaround once the upstream fixes the issue.

Checklist

@raycastbot raycastbot added extension fix / improvement Label for PRs with extension's fix improvements extension: search-npm Issues related to the search-npm extension OP is contributor The OP of the PR is a contributor of the extension labels Feb 4, 2025
@raycastbot
Copy link
Collaborator

Thank you for your contribution! 🎉

🔔 @mrmartineau @reloadedhead @TimonVS @luisFilipePT @LunaticMuch @jomifepe @j3lte @ridemountainpig @DarrylBrooks97 you might want to have a look.

You can use this guide to learn how to check out the Pull Request locally in order to test it.

You can expect an initial review within five business days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extension fix / improvement Label for PRs with extension's fix improvements extension: search-npm Issues related to the search-npm extension OP is contributor The OP of the PR is a contributor of the extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Search npm Packages] Unable to search for packages: URL parsing failed
2 participants