Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC0717: Introducing reactNativeManifest to package.json for React Native specific metadata (Take 3) #717

Open
wants to merge 26 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add clarification on jsonschema
cortinico authored and cipolleschi committed Oct 6, 2023
commit 4b41f0c8b69050fc0b5ec136d648e5447e640ad5
1 change: 1 addition & 0 deletions proposals/0012-introduce-reactNativeMetadata.md
Original file line number Diff line number Diff line change
@@ -227,6 +227,7 @@ Therefore we believe `align-deps` can benefit from this information and be exten
### React Native CLI support

Ideally the CLI (or any other build tool) should be able to consume the `reactNativeManifest` section and warn at build time if a configuration is invalid (either by having an invalid value or by having a mixture of invalid configurations).
For example, the CLI could use [jsonschema](https://npmjs.com/package/jsonschema) at build time and validate the `package.json` against the schema we provide.

It's outside the scope of this RFC to delve into details of which tool will implement which logic and we defer this to a future discussion.