Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated API creds #1

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

developersteve
Copy link

Updated with env system vars instead of coded ones, also updated readme

Updated with env export vars rather than hardcoded
Updated env auth vars
Updated env auth vars
Pushed scope into env vars
@realJoshByrnes
Copy link
Owner

realJoshByrnes commented Sep 15, 2017

@developersteve I'm happy to support these changes, but there's information missing from README.md about setting/requiring system environment variables.

I'm also having a hard time deciding on on supporting backwards-compatibility, which won't require much effort at the moment, but may do so in the future.

What are your thoughts? ~JD

@developersteve
Copy link
Author

@ozjd Was using it for some samples and found it easier to set export vars rather than hard code so thought id push the changes. In hindsight with the new api coming it may not be needed anyway.

Up to you if you want to update

Ah yeah you are right i can update the other parts of the readme if you wanted to add it in

@realJoshByrnes
Copy link
Owner

realJoshByrnes commented Sep 16, 2017

@developersteve If you could update the README, I'll merge the pull request, and I'll make any changes for backwards compatibility shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants