Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a workflow to lock closed issue/PRs #52

Merged
merged 2 commits into from
Mar 14, 2024
Merged

Add a workflow to lock closed issue/PRs #52

merged 2 commits into from
Mar 14, 2024

Conversation

nirinchev
Copy link
Member

No description provided.

@cla-bot cla-bot bot added the cla: yes label Mar 11, 2024
Copy link

@kneth kneth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we agree on a label which prevents closing and locking the issue (and use exclude-any-issue-labels)?

steps:
- uses: dessant/lock-threads@v5
with:
issue-inactive-days: 30
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

30 days might be too short. When you are on summer holidays, three weeks pass quickly.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this does not close issues - it only locks the discussion for already closed ones. In my experience, if a user doesn't respond within a few days of the issue being closed, they won't respond ever, and even if they did, adding a comment 2 months after we've completed some work is rarely useful. I'm fine with increasing that time, just wanted to give some context for how I was thinking about it.

@nirinchev nirinchev merged commit a2191a6 into main Mar 14, 2024
5 checks passed
@nirinchev nirinchev deleted the ni/lock-threads branch March 14, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants