Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing Object Storage Browser p2 [WIP] #11246

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

AviadP
Copy link
Contributor

@AviadP AviadP commented Jan 28, 2025

  • Moved folder generation file
  • now uploading multiple files
  • added new test for getting all buckets list
  • Added list buckets test
  • Added delete bucket test

@AviadP AviadP requested review from a team as code owners January 28, 2025 15:16
@pull-request-size pull-request-size bot added the size/L PR that changes 100-499 lines label Jan 28, 2025
Copy link

openshift-ci bot commented Jan 28, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AviadP

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@AviadP AviadP changed the title Testing Object Storage Browser p2 Testing Object Storage Browser p2 [WIP] Jan 28, 2025
By.XPATH,
),
"storage_class_noobaa_option": (
"#openshift-storage\\.noobaa\\.io-link > a > div:nth-child(1) > span",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will fail if storage namespace is not "openshift-storage"
we'll need to use config.ENV_DATA["cluster_namespace]
also: are you sure about index, that it will be always [1] ? here > div:nth-child(1)

By.XPATH,
),
"create_bucket_button": (
"//*[@id='yaml-create']",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will perform better.
"create_resource_button": ("yaml-create", By.ID), we have it in "generic_locators" dict in views.py. You may remove this and use generic_locators["create_resource_button"]

list: WebElement objects representing bucket links
"""
buckets = self.get_elements(
("//a[starts-with(@href, '/odf/object-storage/buckets/')]", By.XPATH)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please move to views.py

bucket_ui.nav_object_storage_page()
bucket_ui.create_folder_in_bucket()
bucket_ui.nav_buckets_page()
bucket_ui.get_buckets_list()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it some kind of a libtest? do we want to add assertions to validate bucket list?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its WIP. going to compare list by GUI to list by CLI

create bucket via OBC
create bucket via s3
upload folder and file to bucket

Signed-off-by: Aviadp <[email protected]>
Signed-off-by: Aviadp <[email protected]>

Moved folder generation file, also, now uploading multiple files. added new test for getting all buckets list

Signed-off-by: Aviadp <[email protected]>

New test for couning buckets

Signed-off-by: Aviadp <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L PR that changes 100-499 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants