odo dev: Cleanup after displaying the error

[feloy]

What type of PR is this:

/kind bug

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #6023

PR acceptance criteria:

• Unit test

• Integration test

• Documentation

How to test changes / Special notes to the reviewer:

[netlify]

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name	Link
🔨 Latest commit	0c715d3
🔍 Latest deploy log	https://app.netlify.com/sites/odo-docusaurus-preview/deploys/62f51bb9cedb0400083c1907

[odo-robot]

Unit Tests on commit 12f27d8 finished successfully.
View logs: TXT HTML

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[odo-robot]

Windows Tests (OCP) on commit 12f27d8 finished with errors.
View logs: TXT HTML

[odo-robot]

OpenShift Tests on commit 12f27d8 finished successfully.
View logs: TXT HTML

[odo-robot]

Kubernetes Tests on commit 12f27d8 finished successfully.
View logs: TXT HTML

[odo-robot]

Validate Tests on commit 12f27d8 finished successfully.
View logs: TXT HTML

[rm3l]

Thanks.

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rm3l

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rm3l]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dharmit]

/lgtm

[feloy]

Did we increase the Sonar Cloud sensitivity?

The code removes one parameter from the eventWatcher function and does not increase the cognitive complexity of eventWatcher function, and the check now fails, when it was not blocking before.

@valaparthvi @dharmit any idea?

[valaparthvi]

Did we increase the Sonar Cloud sensitivity?

The code removes one parameter from the eventWatcher function and does not increase the cognitive complexity of eventWatcher function, and the check now fails, when it was not blocking before.

@valaparthvi @dharmit any idea?

We haven't made any recent changes to the sonar cloud. We can override them for now. I've marked them as "won't fix" at the moment.

[valaparthvi]

/override windows-integration-test/Windows-test

[openshift-ci]

@valaparthvi: Overrode contexts on behalf of valaparthvi: windows-integration-test/Windows-test

In response to this:

/override windows-integration-test/Windows-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dharmit]

The code removes one parameter from the eventWatcher function and does not increase the cognitive complexity of eventWatcher function, and the check now fails, when it was not blocking before.

Technically, you are correct. But the number of parameters error that SonarCloud raised is something I find a bad idea as well #5933 (comment).

[feloy]

/override ci/prow/v4.10-integration-e2e
Tests pass on IBM cloud

[openshift-ci]

@feloy: Overrode contexts on behalf of feloy: ci/prow/v4.10-integration-e2e

In response to this:

/override ci/prow/v4.10-integration-e2e
Tests pass on IBM cloud

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.