Implement odo delete component --files to delete files generated by odo
#6255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
do-not-merge/work-in-progress
✅ Deploy Preview for odo-docusaurus-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
rm3l
force-pushed
the
5997-odo-delete-component-files-delete-odo-generated-files-and-directories
branch
from
4feb896 to
05317f4
Compare
openshift-merge-robot
added
the
needs-rebase
rm3l
force-pushed
the
5997-odo-delete-component-files-delete-odo-generated-files-and-directories
branch
from
05317f4 to
f28ac06
Compare
openshift-merge-robot
removed
the
needs-rebase
rm3l
removed
the
kind/feature
rm3l
changed the title
odo delete component --filesodo delete component --files to delete files generated by odo
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
rm3l
added
kind/user-story
openshift-merge-robot
added
the
needs-rebase
The end goal is for 'odo delete component --files' to gather a list of files that were initially generated by odo, so as to delete only those. This way, we are less likely to delete the wrong files. This list is collected in a '.odo/generated' file. It will then be up to odo commands to call those methods accordingly. For example, this is called: - by odo init, odo dev, or odo deploy, when generating a new devfile.yaml - by odo dev, when there is no .gitignore file and odo generated one Note that it is quite impossible to cover all scenarios; for example, if odo generates a new devfile.yaml file, but the user deletes it manually and recreates it, 'odo delete component --files' will still list it as a possible candidate for deletion (because it would be listed in .odo/generated).
Co-authored-by: Philippe Martin <[email protected]>
It is more likely to be modified by the user afterward (for another usage). Co-authored-by: Philippe Martin <[email protected]>
rm3l
force-pushed
the
5997-odo-delete-component-files-delete-odo-generated-files-and-directories
branch
from
0bb8f31 to
032e83c
Compare
openshift-merge-robot
removed
the
needs-rebase
|
Rebased and force-pushed to fix the conflicts reported. |
|
/lgtm |
openshift-ci
bot
added
the
lgtm
valaparthvi
suggested changes
Nov 21, 2022
openshift-ci
bot
removed
the
lgtm
|
Kudos, SonarCloud Quality Gate passed!
|
|
/test v4.11-integration-e2e |
|
/override ci/prow/v4.11-integration-e2e /lgtm |
openshift-ci
bot
added
the
lgtm
|
@valaparthvi: Overrode contexts on behalf of valaparthvi: ci/prow/v4.11-integration-e2e In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
3 tasks
rm3l
deleted the
5997-odo-delete-component-files-delete-odo-generated-files-and-directories
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this:
/area component
What does this PR do / why we need it:
See #5997 for the user story.
In a nutshell, this PR adds a new
--filesflag toodo delete component, the goal of which is to delete files that were created byodo.To avoid deleting files we should not, it does so by introducing utility functions at the CLI level, so that commands can report which files they created. The list of files created is then stored in in a dedicated
.odo/generatedfile. This way, we will be able to know which files were initially created by odo and which ones were not.The reason for this is that files like
devfile.yamlmight or might not be created byodo. Also,odo devfor example creates a.gitignorefile if it does not exist. So in some cases, we need to delete those files, and in other cases, we should not touch them.See
c47307b(#6255) and350b9ac(#6255)In all cases, we list all the files that are candidates for deletion and ask the user for confirmation (unless the
--forceflag is used).Which issue(s) this PR fixes:
Fixes #5997
PR acceptance criteria:
Unit test
Integration test
Documentation:
How to test changes / Special notes to the reviewer:
—