-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new --run-port
flag to odo init
to set ports non-interactively
#6953
Merged
openshift-merge-robot
merged 5 commits into
redhat-developer:main
from
rm3l:6925-odo-init-add-new-run-port-flag-to-set-ports-into-initial-devfile
Jul 6, 2023
Merged
Add new --run-port
flag to odo init
to set ports non-interactively
#6953
openshift-merge-robot
merged 5 commits into
redhat-developer:main
from
rm3l:6925-odo-init-add-new-run-port-flag-to-set-ports-into-initial-devfile
Jul 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As depicted in [1], this leverages the default (or single non-default) run command to find the linked container component. As such, it assumes that the command found is an exec command, and that the linked component is a container component. [1] redhat-developer#6925
🔨 Deploy Preview deleted from internal cluster!
|
This ensures the output and sample in the doc are kept in sync with the code base.
7e0f5b1
to
76f96e2
Compare
Kudos, SonarCloud Quality Gate passed!
|
feloy
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/init
Issues or PRs related to `odo init`
kind/feature
Categorizes issue as a feature request. For PRs, that means that the PR is the implementation
lgtm
Indicates that a PR is ready to be merged. Required by Prow.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this:
/kind feature
/area init
What does this PR do / why we need it:
This introduces a new
--run-port
repeatable flag toodo init
, allowing to set application ports non-interactively. It looks into the fetched Devfile for any default (or single non-default) run command; and, if it is an exec command, tries to find the referenced container component to overwrite its endpoints.More context in #6925
Which issue(s) this PR fixes:
Fixes #6925
PR acceptance criteria:
Unit test
Integration test
Documentation
How to test changes / Special notes to the reviewer:
--run-port
--run-port
, even if the Devfile stack in the registry has many container components; example withjava-wildfly
: