Skip to content

Commit

Permalink
Replacing the redis image with redis-libs-tests image in test infrast…
Browse files Browse the repository at this point in the history
…ructure
  • Loading branch information
petyaslavova committed Feb 11, 2025
1 parent 72cdaf6 commit f3e5def
Show file tree
Hide file tree
Showing 5 changed files with 20 additions and 42 deletions.
5 changes: 0 additions & 5 deletions .github/actions/run-tests/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,14 +31,9 @@ runs:
- name: Setup Test environment
env:
REDIS_VERSION: ${{ inputs.redis-version }}
REDIS_IMAGE: "redis:${{ inputs.redis-version }}"
CLIENT_LIBS_TEST_IMAGE: "redislabs/client-libs-test:${{ inputs.redis-version }}"
run: |
set -e
if [ "${{inputs.redis-version}}" == "8.0-M04-pre" ]; then
export REDIS_IMAGE=redis:8.0-M03
fi
echo "::group::Installing dependencies"
pip install -U setuptools wheel
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/integration.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ env:
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
# this speeds up coverage with Python 3.12: https://github.com/nedbat/coveragepy/issues/1665
COVERAGE_CORE: sysmon
REDIS_IMAGE: redis:latest
REDIS_STACK_IMAGE: redis/redis-stack-server:latest
CURRENT_REDIS_VERSION: '7.4.2'

Expand Down Expand Up @@ -181,7 +180,6 @@ jobs:
- name: Run installed unit tests
env:
REDIS_VERSION: ${{ env.CURRENT_REDIS_VERSION }}
REDIS_IMAGE: "redis:${{ env.CURRENT_REDIS_VERSION }}"
CLIENT_LIBS_TEST_IMAGE: "redislabs/client-libs-test:${{ env.CURRENT_REDIS_VERSION }}"
run: |
bash .github/workflows/install_and_test.sh ${{ matrix.extension }}
Expand Down
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -23,3 +23,5 @@ docker/stunnel/keys
/dockers/*/tls/*
/dockers/standalone/
/dockers/cluster/
/dockers/replica/
/dockers/sentinel/
51 changes: 17 additions & 34 deletions docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,19 @@ services:
- all

replica:
image: ${REDIS_IMAGE:-redis:7.4.1}
image: ${CLIENT_LIBS_TEST_IMAGE:-redislabs/client-libs-test:7.4.1}
container_name: redis-replica
depends_on:
- redis
command: redis-server --replicaof redis 6379 --protected-mode no --save ""
environment:
- TLS_ENABLED=no
- REDIS_CLUSTER=no
- PORT=6380
command: ${REDIS_EXTRA_ARGS:---enable-debug-command yes --replicaof redis 6379 --protected-mode no --save ""}
ports:
- 6380:6379
- 6380:6380
volumes:
- "./dockers/replica:/redis/work"
profiles:
- replica
- all-stack
Expand Down Expand Up @@ -58,45 +64,22 @@ services:
- all

sentinel:
image: ${REDIS_IMAGE:-redis:7.4.1}
image: ${CLIENT_LIBS_TEST_IMAGE:-redislabs/client-libs-test:7.4.1}
container_name: redis-sentinel
depends_on:
- redis
entrypoint: "redis-sentinel /redis.conf --port 26379"
environment:
- REDIS_CLUSTER=no
- NODES=3
- PORT=26379
command: ${REDIS_EXTRA_ARGS:---sentinel}
ports:
- 26379:26379
volumes:
- "./dockers/sentinel.conf:/redis.conf"
profiles:
- sentinel
- all-stack
- all

sentinel2:
image: ${REDIS_IMAGE:-redis:7.4.1}
container_name: redis-sentinel2
depends_on:
- redis
entrypoint: "redis-sentinel /redis.conf --port 26380"
ports:
- 26380:26380
volumes:
- "./dockers/sentinel.conf:/redis.conf"
profiles:
- sentinel
- all-stack
- all

sentinel3:
image: ${REDIS_IMAGE:-redis:7.4.1}
container_name: redis-sentinel3
depends_on:
- redis
entrypoint: "redis-sentinel /redis.conf --port 26381"
ports:
- 26381:26381
volumes:
- "./dockers/sentinel.conf:/redis.conf"
- "./dockers/sentinel.conf:/redis/config-default/redis.conf"
- "./dockers/sentinel:/redis/work"
profiles:
- sentinel
- all-stack
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
long_description_content_type="text/markdown",
keywords=["Redis", "key-value store", "database"],
license="MIT",
version="5.1.1",
version="5.3.0",
packages=find_packages(
include=[
"redis",
Expand Down

0 comments on commit f3e5def

Please sign in to comment.