Skip to content

Commit

Permalink
feat: change Z member type to string in rueidiscompat to align go-redis
Browse files Browse the repository at this point in the history
  • Loading branch information
rueian committed Dec 7, 2023
1 parent d25943e commit 3851dec
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion rueidiscompat/adapter.go
Original file line number Diff line number Diff line change
Expand Up @@ -1905,7 +1905,7 @@ func (c *Compat) zAddArgs(ctx context.Context, key string, incr bool, args ZAddA
cmd = cmd.Args("INCR")
}
for _, v := range args.Members {
cmd = cmd.Args(strconv.FormatFloat(v.Score, 'f', -1, 64), str(v.Member))
cmd = cmd.Args(strconv.FormatFloat(v.Score, 'f', -1, 64), v.Member)
}
resp := c.client.Do(ctx, cmd.Build())
return resp
Expand Down
8 changes: 4 additions & 4 deletions rueidiscompat/adapter_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -3612,28 +3612,28 @@ func testAdapter(resp3 bool) {
It("should ZAdd bytes", func() {
added, err := adapter.ZAdd(ctx, "zset", Z{
Score: 1,
Member: []byte("one"),
Member: "one",
}).Result()
Expect(err).NotTo(HaveOccurred())
Expect(added).To(Equal(int64(1)))

added, err = adapter.ZAdd(ctx, "zset", Z{
Score: 1,
Member: []byte("uno"),
Member: "uno",
}).Result()
Expect(err).NotTo(HaveOccurred())
Expect(added).To(Equal(int64(1)))

added, err = adapter.ZAdd(ctx, "zset", Z{
Score: 2,
Member: []byte("two"),
Member: "two",
}).Result()
Expect(err).NotTo(HaveOccurred())
Expect(added).To(Equal(int64(1)))

added, err = adapter.ZAdd(ctx, "zset", Z{
Score: 3,
Member: []byte("two"),
Member: "two",
}).Result()
Expect(err).NotTo(HaveOccurred())
Expect(added).To(Equal(int64(0)))
Expand Down
2 changes: 1 addition & 1 deletion rueidiscompat/command.go
Original file line number Diff line number Diff line change
Expand Up @@ -1865,7 +1865,7 @@ func (cmd *XInfoConsumersCmd) Result() ([]XInfoConsumer, error) {

// Z represents sorted set member.
type Z struct {
Member any
Member string
Score float64
}

Expand Down

0 comments on commit 3851dec

Please sign in to comment.