Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ACLLog to rueidiscompat #744

Merged
merged 3 commits into from
Feb 9, 2025
Merged

Conversation

blueBlue0102
Copy link
Contributor

#737

I have run the unit tests multiple times locally, and each time, a different test seems to fail unpredictably.
I'm not sure if this is an issue specific to my local environment.

Unit test results:
image
image
image

@rueian
Copy link
Collaborator

rueian commented Feb 9, 2025

Hi @blueBlue0102, thank you so much but could you keep the ClientInfo parser in the rueidiscompat? I currently have no plan to add ClientInfo and ACLLogEntry to message.go.

@blueBlue0102
Copy link
Contributor Author

Hi @rueian, I've already moved it back to rueidiscompat and created a new method, stringToClientInfo, for parsing. Please let me know if there's anything else that needs to be adjusted.

@rueian rueian merged commit e3091a3 into redis:main Feb 9, 2025
19 checks passed
@rueian
Copy link
Collaborator

rueian commented Feb 9, 2025

Thanks again. LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants