-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Draft]: Try Node 18 on CI #6073
Conversation
dac09
commented
Jul 28, 2022
•
edited
Loading
edited
- Bumps up the max supported version from 16.x to 18.x
- Modifies the CI to run on Node 16 and 18 (dropping Node 14, but haven't removed from package.json)
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 00e36df. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 14 targets
Sent with 💌 from NxCloud. |
✅ Deploy Preview for redwoodjs-docs canceled.
|
@dac09 right now the smoke-tests are failing due to prisma migrations. Do we need the new migrations added here? All we're doing is widening the Node.js version range
|
Cypress on Node.js 16 is running great, but times out immediately on 18. Looks like others are seeing the same thing: |
Closing in favor of #7183 |