Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft]: Try Node 18 on CI #6073

Closed
wants to merge 10 commits into from
Closed

[Draft]: Try Node 18 on CI #6073

wants to merge 10 commits into from

Conversation

dac09
Copy link
Contributor

@dac09 dac09 commented Jul 28, 2022

  • Bumps up the max supported version from 16.x to 18.x
  • Modifies the CI to run on Node 16 and 18 (dropping Node 14, but haven't removed from package.json)

@nx-cloud
Copy link

nx-cloud bot commented Jul 28, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 00e36df. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 14 targets

Sent with 💌 from NxCloud.

@netlify
Copy link

netlify bot commented Jul 28, 2022

Deploy Preview for redwoodjs-docs canceled.

Name Link
🔨 Latest commit 00e36df
🔍 Latest deploy log https://app.netlify.com/sites/redwoodjs-docs/deploys/63006c826a8c270008441bad

@dac09 dac09 added the release:feature This PR introduces a new feature label Jul 28, 2022
@jtoar
Copy link
Contributor

jtoar commented Aug 20, 2022

@dac09 right now the smoke-tests are failing due to prisma migrations. Do we need the new migrations added here? All we're doing is widening the Node.js version range

Applying migration `20220728143002_create_product`
Applying migration `20220728143011_create_contact`
Applying migration `20220728143109_db_auth`
Applying migration `20220809160848_create_post_user`
Error: P3018

A migration failed to apply. New migrations cannot be applied before the error is recovered from. Read more about how to resolve migration issues in a production database: https://pris.ly/d/migrate-resolve

@jtoar
Copy link
Contributor

jtoar commented Aug 20, 2022

Cypress on Node.js 16 is running great, but times out immediately on 18. Looks like others are seeing the same thing:

@jtoar
Copy link
Contributor

jtoar commented Dec 15, 2022

Closing in favor of #7183

@jtoar jtoar closed this Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:feature This PR introduces a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants