Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few more updates for index publication #88

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

bsweger
Copy link
Collaborator

@bsweger bsweger commented Jan 13, 2025

This PR contains two unrelated commits that tweak a few things to ensure that Cladetime is ready for PyPI and test-PyPI

While `uv venv` does create a virtual environment in the standard location
(a .venv folder in the currenet directory), it does not install "seed"
packages like pep, setuptools, and wheel into it. For people used to standard
pip incantations (e.g., `pip list`), this behavior is confusing because they
now have to use `uv pip list`, even after they manually activated the uv-created
environment.

I.e., this series of commands will not produce a list of environemnt packages:
- `uv venv`
- manually activate the venv the old-fashioned way: source .venv/bin/activate
- pip list

However, passing the --seed option allows the above commands to work as
expected by people who retain muscle memory for the old ways.
…anches

Cladetime is using setuptools-scm to dynamically determine the package version.
This commit address an issue with CI builds where the version was not
incorporating the latest tags.
@bsweger bsweger requested a review from zkamvar January 13, 2025 16:28
Copy link
Member

@zkamvar zkamvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I appreciate the commit message detail.

I always forget about the fetch-depth option (though I massively appreciate the default to not pull everything down at once).

@bsweger bsweger merged commit e829a64 into main Jan 13, 2025
3 checks passed
@bsweger bsweger deleted the bs/additional-publication-tweaks/80 branch January 13, 2025 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants