Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin third-party GitHub actions by commit hash and add explicit workflow permissions #93

Merged
merged 2 commits into from
Feb 28, 2025

Conversation

bsweger
Copy link
Collaborator

@bsweger bsweger commented Feb 26, 2025

Closes #90

Yesterday's PR closed most of our outstanding security alerts, and this one should close out the rest.

The changes:

  • pin third-party actions using commit hashes instead of tags.
  • make sure each workflow has explicit GITHUB_TOKEN permissions

Unrelated but interesting: the CODEOWNERS file merged yesterday is doing its thing! (it specifies that at least one reviewer from the code-owner team has to approve workflow updates):

image

@bsweger bsweger requested a review from a team as a code owner February 26, 2025 19:54
@bsweger bsweger marked this pull request as draft February 26, 2025 20:55
@bsweger bsweger changed the title Pin third-party GitHub actions by commit hash instead of tag Pin third-party GitHub actions by commit hash and add explicit workflow permissions Feb 26, 2025
@bsweger bsweger marked this pull request as ready for review February 26, 2025 21:10
Copy link
Collaborator

@lshandross lshandross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (though I didn't go and double check the commit hashes are correct)

@bsweger bsweger merged commit a6f0223 into main Feb 28, 2025
6 checks passed
@bsweger bsweger deleted the bs/more-security-updates/90 branch February 28, 2025 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Cladetime security alerts
2 participants