handle quiet audio waves #4820
Merged
handle quiet audio waves #4820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Thanks a lot! 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When processing extremely quiet audio (max amplitude < 0.001), the waveform visualization would over-amplify the noise due to normalization. This would make silent or near-silent sections appear as prominent waves.
For example, when I'm splitting this audio out into individual stems, it is common that one of the instruments is not present. In this screenshot, there is no piano:
This now treats audio below this threshold as silence by returning zeros instead of normalizing. Here are what the stems look like now:
Note that I still place a dot for the waveform when amplitude is zero, but that is in the canvas logic.