Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wait-on step in screenshot workflow #9173

Closed
wants to merge 1 commit into from
Closed

Conversation

hbenl
Copy link
Contributor

@hbenl hbenl commented May 10, 2023

No description provided.

@hbenl hbenl self-assigned this May 10, 2023
@vercel
Copy link

vercel bot commented May 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
devtools ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2023 10:24am

@qa-wolf
Copy link

qa-wolf bot commented May 10, 2023

@replay-io
Copy link

replay-io bot commented May 10, 2023

62 replays were recorded for 9daa928.

image 0 Failed
image 62 Passed
  • cypress-01: Test basic cypress reporter functionality
  • breakpoints-01: Test basic breakpoint functionality
          ```
          expect(received).toBeGreaterThan(expected)
          
          Expected: > 0
          Received:   0
          ```
        </ol>
      </details>
      <details>
        <summary><a href=https://app.replay.io/recording/a145043e-2252-484a-97ec-01eb6f508889>breakpoints-02: Test unhandled divergence while evaluating at a breakpoint</a></summary>
        <ol type="1">
          
          ```
          expect(received).toBeGreaterThan(expected)
          
          Expected: > 0
          Received:   0
          ```
        </ol>
      </details>
      <details>
        <summary><a href=https://app.replay.io/recording/04df3d80-1ea4-4e0a-8144-891a9eaeab92>breakpoints-03: Test stepping forward through breakpoints when rewound before the first one</a></summary>
        <ol type="1">
          
          ```
          expect(received).toBeGreaterThan(expected)
          
          Expected: > 0
          Received:   0
          ```
        </ol>
      </details>
      <details>
        <summary><a href=https://app.replay.io/recording/6f0b03ea-8a72-400f-88ce-ec4ad14a896b>breakpoints-04: catch, finally, generators, and async/await</a></summary>
        <ol type="1">
          
          ```
          expect(received).toBeGreaterThan(expected)
          
          Expected: > 0
          Received:   0
          ```
        </ol>
      </details>
      <details>
        <summary><a href=https://app.replay.io/recording/edafd392-a621-4543-b367-38ab4cfe2e8e>breakpoints-05: Test interaction of breakpoints with debugger statements</a></summary>
        <ol type="1">
          
          ```
          expect(received).toBeGreaterThan(expected)
          
          Expected: > 0
          Received:   0
          ```
        </ol>
      </details>
      <li><a href=https://app.replay.io/recording/84fad6fe-3e32-4ca1-bca1-cccc9837ceea>breakpoints-06: Test log point in a sourcemapped file</a></li>
      <details>
        <summary><a href=https://app.replay.io/recording/a951fcf1-9565-4515-bec7-15d07f7fe713>breakpoints-07: rewind and seek using command bar and console messages</a></summary>
        <ol type="1">
          
          ```
          expect(received).toBeGreaterThan(expected)
          
          Expected: > 0
          Received:   0
          ```
        </ol>
      </details>
      <li><a href=https://app.replay.io/recording/bd6a3c31-8864-4c2b-a146-4d0ef3c4ebe9>breakpoints-08: should be temporarily disabled</a></li>
      <details>
        <summary><a href=https://app.replay.io/recording/17d73a23-e2f7-4585-b146-2712e1f6be60>console_async: support console evaluations in async frames</a></summary>
        <ol type="1">
          
          ```
          expect(received).toBeGreaterThan(expected)
          
          Expected: > 0
          Received:   0
          ```
        </ol>
      </details>
      <li><a href=https://app.replay.io/recording/53d6dbdc-4604-4fc1-861b-737481f8264f>console_dock_node: Should show the correct docking behavior for recordings without video</a></li>
      <li><a href=https://app.replay.io/recording/1409dcc3-9f1b-478f-a3b3-35f26e9d63f6>console_dock: Should show the correct docking behavior for recordings with video</a></li>
      <li><a href=https://app.replay.io/recording/3af8fc7b-f4f1-416f-a0f4-eae6bb99ed68>console_errors: Test that errors and warnings from various sources are shown in the console</a></li>
      <details>
        <summary><a href=https://app.replay.io/recording/67984b54-617c-4c49-900f-9403637cfdc8>console_eval: support console evaluations</a></summary>
        <ol type="1">
          
          ```
          expect(received).toBe(expected) // Object.is equality
          
          Expected: "true"
          Received: "false"
          ```
        </ol>
      </details>
      <details>
        <summary><a href=https://app.replay.io/recording/b20c75ee-9a7d-4d19-a267-c2fd8e8f86ea>console_warp-01: should support warping to console messages</a></summary>
        <ol type="1">
          
          ```
          expect(received).toBe(expected) // Object.is equality
          
          Expected: "true"
          Received: "false"
          ```
        </ol>
      </details>
      <details>
        <summary><a href=https://app.replay.io/recording/aab6515b-86c7-48f9-a6cd-0d86d07ffffe>console_warp-02: support pausing, warping, stepping and evaluating console messages</a></summary>
        <ol type="1">
          
          ```
          expect(received).toBeGreaterThan(expected)
          
          Expected: > 0
          Received:   0
          ```
        </ol>
      </details>
      <details>
        <summary><a href=https://app.replay.io/recording/b4a95423-d69d-4bd7-8b2c-58007d0a68ad>console-expressions-01: should cache input eager eval and terminal expressions per instance</a></summary>
        <ol type="1">
          
          ```
          expect(received).toBe(expected) // Object.is equality
          
          Expected: "true"
          Received: "false"
          ```
        </ol>
      </details>
      <li><a href=https://app.replay.io/recording/53e10bfb-09b4-45fe-be0a-b53561c1834b>focus_mode-01: should filter messages as regions based on the active focus mode</a></li>
      <details>
        <summary><a href=https://app.replay.io/recording/fbadb82d-d9ea-42e2-93b8-4b01b7d5220b>highlighter: element highlighter works everywhere</a></summary>
        <ol type="1">
          
          ```
          expect(received).toBe(expected) // Object.is equality
          
          Expected: "true"
          Received: "false"
          ```
        </ol>
      </details>
      <details>
        <summary><a href=https://app.replay.io/recording/e4c23cf5-f020-40d8-a30b-edf583452e6e>inspector-01: Test that scopes are rerendered</a></summary>
        <ol type="1">
          
          ```
          expect(received).toBeGreaterThan(expected)
          
          Expected: > 0
          Received:   0
          ```
        </ol>
      </details>
      <details>
        <summary><a href=https://app.replay.io/recording/730c6365-0e2c-462d-b2bc-87767788a3e6>inspector-02: element picker and iframe behavior</a></summary>
        <ol type="1">
          
          ```
          expect(received).toBeGreaterThan(expected)
          
          Expected: > 0
          Received:   0
          ```
        </ol>
      </details>
      <details>
        <summary><a href=https://app.replay.io/recording/cd17665b-91f4-465a-be59-23ed1d350f18>inspector-03: Test that styles for elements can be viewed</a></summary>
        <ol type="1">
          
          ```
          expect(received).toBeGreaterThan(expected)
          
          Expected: > 0
          Received:   0
          ```
        </ol>
      </details>
      <details>
        <summary><a href=https://app.replay.io/recording/40d7c430-5e06-40a3-9bb2-a08b478a10d7>inspector-04: Test that styles for elements can be viewed</a></summary>
        <ol type="1">
          
          ```
          expect(received).toBe(expected) // Object.is equality
          
          Expected: "true"
          Received: "false"
          ```
        </ol>
      </details>
      <details>
        <summary><a href=https://app.replay.io/recording/e4b80296-be06-40f1-9191-7c303e357a10>inspector-05: Test that styles for elements can be viewed</a></summary>
        <ol type="1">
          
          ```
          expect(received).toBeGreaterThan(expected)
          
          Expected: > 0
          Received:   0
          ```
        </ol>
      </details>
      <details>
        <summary><a href=https://app.replay.io/recording/f313cf16-aafa-4cf8-86e9-e5fc5e1fc794>inspector-06: Test that styles for elements can be viewed</a></summary>
        <ol type="1">
          
          ```
          expect(received).toBe(expected) // Object.is equality
          
          Expected: "true"
          Received: "false"
          ```
        </ol>
      </details>
      <details>
        <summary><a href=https://app.replay.io/recording/061f1030-ec54-46b9-95e9-3a23ea811eda>inspector-07: Test that styles for elements can be viewed</a></summary>
        <ol type="1">
          
          ```
          expect(received).toBeGreaterThan(expected)
          
          Expected: > 0
          Received:   0
          ```
        </ol>
      </details>
      <details>
        <summary><a href=https://app.replay.io/recording/2273c298-edb6-4c73-9065-3283dfb9c64d>logpoints-01: log-points appear in the correct order and allow time warping</a></summary>
        <ol type="1">
          
          ```
          expect(received).toBe(expected) // Object.is equality
          
          Expected: "true"
          Received: "false"
          ```
        </ol>
      </details>
      <li><a href=https://app.replay.io/recording/dc680400-f243-4002-9d5c-f08f74722932>logpoints-02: conditional log-points</a></li>
      <li><a href=https://app.replay.io/recording/f1344df6-0b34-4e29-a4b0-50add7f8e771>logpoints-03_chromium: should display event properties in the console</a></li>
      <li><a href=https://app.replay.io/recording/4a7cea27-5f3d-4dce-b618-7a85beeb5744>logpoints-03: should display event properties in the console</a></li>
      <details>
        <summary><a href=https://app.replay.io/recording/1eece3b0-0711-4bb3-bb98-0068adf031d3>logpoints-04: should display exceptions in the console</a></summary>
        <ol type="1">
          
          ```
          expect(received).toBe(expected) // Object.is equality
          
          Expected: "true"
          Received: "false"
          ```
        </ol>
      </details>
      <details>
        <summary><a href=https://app.replay.io/recording/7077d90b-2a98-4fd2-b8ef-bba6372c4f78>logpoints-05: should auto-complete based on log point location</a></summary>
        <ol type="1">
          
          ```
          expect(received).toContain(expected) // indexOf
          
          Expected value: "arrayGlobal"
          Received array: []
          ```
        </ol>
      </details>
      <li><a href=https://app.replay.io/recording/6b20665c-829d-42b3-aba5-bdeb41cc1078>logpoints-06: should be temporarily disabled</a></li>
      <details>
        <summary><a href=https://app.replay.io/recording/9db45acd-2bb7-4467-b21e-78a1ab110cd5>logpoints-07: should use the correct scope in auto-complete</a></summary>
        <ol type="1">
          
          ```
          expect(received).toBe(expected) // Object.is equality
          
          Expected: "true"
          Received: "false"
          ```
        </ol>
      </details>
      <li><a href=https://app.replay.io/recording/eaafbc71-aac9-4a7b-a4cb-9a4565df809c>logpoints-08: should support jumping directly to a hit point via the capsule input</a></li>
      <details>
        <summary><a href=https://app.replay.io/recording/2236e088-6538-42d9-9b8e-f4e67e575aa4>node_console-01: Basic node console behavior</a></summary>
        <ol type="1">
          
          ```
          expect(received).toBe(expected) // Object.is equality
          
          Expected: "true"
          Received: "false"
          ```
        </ol>
      </details>
      <details>
        <summary><a href=https://app.replay.io/recording/86c6605a-4582-4f56-ac0c-4d37db336504>node_console-02: uncaught exceptions should show up</a></summary>
        <ol type="1">
          
          ```
          expect(received).toBeGreaterThan(expected)
          
          Expected: > 0
          Received:   0
          ```
        </ol>
      </details>
      <details>
        <summary><a href=https://app.replay.io/recording/2b508afb-ec67-4852-98e9-b169746c2edd>node_control_flow: catch, finally, generators, and async/await</a></summary>
        <ol type="1">
          
          ```
          expect(received).toBeGreaterThan(expected)
          
          Expected: > 0
          Received:   0
          ```
        </ol>
      </details>
      <details>
        <summary><a href=https://app.replay.io/recording/35f8b334-f732-4f36-8cf5-d2f540846e9e>node_logpoint-01: Basic node logpoints</a></summary>
        <ol type="1">
          
          ```
          expect(received).toBeGreaterThan(expected)
          
          Expected: > 0
          Received:   0
          ```
        </ol>
      </details>
      <details>
        <summary><a href=https://app.replay.io/recording/49eec88c-6ad6-48ad-b615-ae5aeab75455>node_logpoint-02: Node exception logpoints</a></summary>
        <ol type="1">
          
          ```
          expect(received).toBe(expected) // Object.is equality
          
          Expected: true
          Received: false
          ```
        </ol>
      </details>
      <li><a href=https://app.replay.io/recording/9022ad3a-dc99-4eb1-bc2b-4c697b39b664>node_object_preview: Showing console objects in node</a></li>
      <details>
        <summary><a href=https://app.replay.io/recording/4022749f-bd05-4723-bd09-9f6a54e9243f>node_spawn: Basic subprocess spawning</a></summary>
        <ol type="1">
          
          ```
          expect(received).toBe(expected) // Object.is equality
          
          Expected: "true"
          Received: "false"
          ```
        </ol>
      </details>
      <details>
        <summary><a href=https://app.replay.io/recording/4e9f310f-bb41-4da4-941c-a55692a5c4dc>node_stepping-01: Test stepping in async frames and async call stacks</a></summary>
        <ol type="1">
          
          ```
          expect(received).toBeGreaterThan(expected)
          
          Expected: > 0
          Received:   0
          ```
        </ol>
      </details>
      <details>
        <summary><a href=https://app.replay.io/recording/ad2524c0-d9b0-46aa-932d-23e721c06469>node_worker-01: make sure node workers don't cause crashes</a></summary>
        <ol type="1">
          
          ```
          expect(received).toBeGreaterThan(expected)
          
          Expected: > 0
          Received:   0
          ```
        </ol>
      </details>
      <details>
        <summary><a href=https://app.replay.io/recording/35f90251-8163-47e1-adec-642008a4f506>object_preview-01: expressions in the console after time warping</a></summary>
        <ol type="1">
          
          ```
          expect(received).toBe(expected) // Object.is equality
          
          Expected: "true"
          Received: "false"
          ```
        </ol>
      </details>
      <details>
        <summary><a href=https://app.replay.io/recording/906ded12-8216-4996-ae41-2cb799cc1f26>object_preview-02: should allow objects in scope to be inspected</a></summary>
        <ol type="1">
          
          ```
          expect(received).toBe(expected) // Object.is equality
          
          Expected: "true"
          Received: "false"
          ```
        </ol>
      </details>
      <details>
        <summary><a href=https://app.replay.io/recording/50029a24-bee4-4462-8bd4-2ce21f569427>object_preview-03: Test previews when switching between frames and stepping</a></summary>
        <ol type="1">
          
          ```
          expect(received).toBeGreaterThan(expected)
          
          Expected: > 0
          Received:   0
          ```
        </ol>
      </details>
      <details>
        <summary><a href=https://app.replay.io/recording/73ee3064-70bc-4fe7-92ad-9cf290c9c220>object_preview-04: Test scope mapping and switching between generated/original sources</a></summary>
        <ol type="1">
          
          ```
          expect(received).toBe(expected) // Object.is equality
          
          Expected: "true"
          Received: "false"
          ```
        </ol>
      </details>
      <details>
        <summary><a href=https://app.replay.io/recording/6079577c-3ef3-4bb1-a168-237238227354>object_preview-05: Should support logging objects as values</a></summary>
        <ol type="1">
          
          ```
          expect(received).toBeGreaterThan(expected)
          
          Expected: > 0
          Received:   0
          ```
        </ol>
      </details>
      <details>
        <summary><a href=https://app.replay.io/recording/498b68e8-48c7-4e89-8c76-0e78368dc637>react_devtools: Test React DevTools.</a></summary>
        <ol type="1">
          
          ```
          expect(received).toBe(expected) // Object.is equality
          
          Expected: "true"
          Received: "false"
          ```
        </ol>
      </details>
      <details>
        <summary><a href=https://app.replay.io/recording/ceb688c5-c5f2-4313-a0b0-d27f152660cd>repaint: repaints the screen screen when stepping over code that modifies the DOM</a></summary>
        <ol type="1">
          
          ```
          expect(received).toBeGreaterThan(expected)
          
          Expected: > 0
          Received:   0
          ```
        </ol>
      </details>
      <li><a href=https://app.replay.io/recording/0bef98e1-4b90-4001-8fae-ed333858613b>resizable-panels-01: Left side Toolbar should be collapsible</a></li>
      <details>
        <summary><a href=https://app.replay.io/recording/8641b7d1-d618-45ea-99df-c044614de61f>scopes_rerender: Test that scopes are rerendered</a></summary>
        <ol type="1">
          
          ```
          expect(received).toBe(expected) // Object.is equality
          
          Expected: "true"
          Received: "false"
          ```
        </ol>
      </details>
      <details>
        <summary><a href=https://app.replay.io/recording/6854828a-6ba1-40c5-b528-5be7725b4fb4>sourcemap_stacktrace: Test that stacktraces are sourcemapped</a></summary>
        <ol type="1">
          
          ```
          expect(received).toEqual(expected) // deep equality
          
          - Expected  - 9
          + Received  + 1
          
          - Array [
          -   "App.js:9",
          -   "App.js:33",
          -   "regeneratorRuntime.js:44",
          -   "regeneratorRuntime.js:125",
          ```
        </ol>
      </details>
      <details>
        <summary><a href=https://app.replay.io/recording/a829e55e-6a5c-4c1f-bb62-98fade8a921c>stacking: Element highlighter selects the correct element when they overlap</a></summary>
        <ol type="1">
          
          ```
          expect(received).toBeGreaterThan(expected)
          
          Expected: > 0
          Received:   0
          ```
        </ol>
      </details>
      <details>
        <summary><a href=https://app.replay.io/recording/ca5e49b6-dfc6-482b-b1dc-a7013f629cf5>stepping-01: Test basic step-over/back functionality</a></summary>
        <ol type="1">
          
          ```
          expect(received).toBeGreaterThan(expected)
          
          Expected: > 0
          Received:   0
          ```
        </ol>
      </details>
      <details>
        <summary><a href=https://app.replay.io/recording/965946e0-3229-4e63-be13-0d70f3976fba>stepping-02: Test fixes for some simple stepping bugs</a></summary>
        <ol type="1">
          
          ```
          expect(received).toBeGreaterThan(expected)
          
          Expected: > 0
          Received:   0
          ```
        </ol>
      </details>
      <details>
        <summary><a href=https://app.replay.io/recording/1007ac02-041b-47df-9b45-5a154cba92c5>stepping-03: Stepping past the beginning or end of a frame should act like a step-out</a></summary>
        <ol type="1">
          
          ```
          expect(received).toBeGreaterThan(expected)
          
          Expected: > 0
          Received:   0
          ```
        </ol>
      </details>
      <details>
        <summary><a href=https://app.replay.io/recording/e579f670-ec3e-4fe1-945e-e7310d2eff72>stepping-04: Test stepping in a frame other than the top frame</a></summary>
        <ol type="1">
          
          ```
          expect(received).toBe(expected) // Object.is equality
          
          Expected: "true"
          Received: "false"
          ```
        </ol>
      </details>
      <details>
        <summary><a href=https://app.replay.io/recording/44692c21-5746-4301-823c-982326387488>stepping-05_chromium: Test stepping in pretty-printed code</a></summary>
        <ol type="1">
          
          ```
          expect(received).toBeGreaterThan(expected)
          
          Expected: > 0
          Received:   0
          ```
        </ol>
      </details>
      <details>
        <summary><a href=https://app.replay.io/recording/38966cbb-6e66-4c77-bf76-9d2ad85fb0f7>stepping-05: Test stepping in pretty-printed code</a></summary>
        <ol type="1">
          
          ```
          expect(received).toBeGreaterThan(expected)
          
          Expected: > 0
          Received:   0
          ```
        </ol>
      </details>
      <details>
        <summary><a href=https://app.replay.io/recording/4a6f9087-abe2-4ef0-bcd8-e31e5adb46ce>stepping-06: Test stepping in async frames and async call stacks</a></summary>
        <ol type="1">
          
          ```
          expect(received).toBe(expected) // Object.is equality
          
          Expected: "true"
          Received: "false"
          ```
        </ol>
      </details>
      

View test run on Replay ↗︎

@hbenl
Copy link
Contributor Author

hbenl commented May 10, 2023

I thought the problem was caused by jeffbski/wait-on#133 but apparently it wasn't.

@hbenl hbenl closed this May 10, 2023
@hbenl hbenl deleted the hbenl/fix-wait-on branch May 10, 2023 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant