Fix Bash completion filename

[hartwork]

In reaction to https://github.com/gentoo/gentoo/blob/2d9d9245cafbbc8ff381f4c0c6509fa8f4c91af9/sys-apps/dcfldd/dcfldd-1.9.2.ebuild#L37-L38

The original QA notice in Gentoo was:

 * QA Notice: Problems with installed bash completions were found:
 * 
 *      dcfldd-bash_completion: incorrect name, no completions for 'dcfldd-bash_completion' command defined.
 *      dcfldd: missing alias (symlink) for completed command.
 * 
 * For more details on installing bash-completions, please see:
 * https://wiki.gentoo.org/wiki/Bash/Installing_completion_files

@davidpolverari what do you think?

[davidpolverari]

Hmm, I will have another look at that. I remember us testing this, right? I thought we had no problems with the current implementation (see #15 and #18), but if we have to rename the file, no problems about that. Let me just test it again.

[hartwork]

@davidpolverari it's probably not "have to" technically, but the current name is definitely not ideal and if I don't address the QA warning in Gentoo somehow, people will come to me and complain and have a point.

[hartwork]

@davidpolverari PS: in Debian I find the dd bash completion at /usr/share/bash-completion/completions/dd (https://packages.debian.org/bookworm/all/bash-completion/filelist) so name dcfldd would likele be expected there. To be fair. there's also four files taking a different pattern: https://packages.debian.org/search?searchon=contents&keywords=.bash-completion&mode=filename&suite=stable&arch=any

[davidpolverari]

Yes, I understand. I'm just trying to understand why the file was named that way in the first place. The examples you picked from Debian show that either bash-completions is too lenient, or those completions don't work. From what I read in bash-completions docs, the file should be named dcfldd or dcfldd.bash, which is inline with what you proposed.

I will just try to figure out why the file was named like that, but the change LGTM.

[hartwork]

@davidpolverari cool! 👍

[davidpolverari]

As we are going to create a new dir to host the completions file, why don't we use the dash (bash-completion) instead of the underscore (bash_completion)? Besides being easier to change into the directory, it is more in line with the bash-completion's own directory naming (and project naming), too.

[hartwork]

@davidpolverari I'm leaning towards _ (underscore) personally in most places with filenames, in particular folder names, but no strong feelings or arguments about it, I just changed it to what you suggested.