several tidy-ups of code #61
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marksmayo
commented
May 26, 2023
marksmayo
commented
- all tests pass
- no files removed/added
- only language updates, cleaning
- added f-strings and tidied imports
- cleaned whitespace, unncessary f-strings, naked excepts
- removed u-prefixes
- updated deprecated optparse to argparse
-
- fix singleton comparisons
- made rsplot more accurate
- simplfied if statements
- fixed a bunch of flake8 warnings, including spaces, docstrings, alignments, trailing commas and other language cleanups.
Used flynt and isort to clean up imports and replace several format strings with f-strings.
Added exception to naked excepts Cleaned up trailing whitespace Removed f-strings where no substituted values occured
don't need to inherit from object
The u prefix for strings is no longer necessary in Python >=3.0
line was indented too far
exit() more for REPL
Now using argparse
simplifying and removing one redundant one
with min where possible used dict literals
- space after # in comments - trailing commas - tidy whitespace around brackets, symbols - clean up docstrings - spacing between functions - docstrings punctuated - alignment of hanging lines - spaces around operators - indentation of blocks
rgerum
reviewed
May 26, 2023
| @@ -285,7 +284,7 @@ def warnAboutTicks(fig): | |||
| print("Warning tick and label differ", t, l, "for axes", ax_name, file=sys.stderr) | |||
|
|
|||
|
|
|||
| """ Window """ | |||
| """ Window. """ | |||
There was a problem hiding this comment.
I don't see why a comment that is not a sentence should have a period at the end.
rgerum
reviewed
May 26, 2023
| @@ -192,7 +191,7 @@ def show(hide_window: bool = False): | |||
| if setting_use_global_variable_names: | |||
| setFigureVariableNames(figure) | |||
| # get the window | |||
| #window = _pylab_helpers.Gcf.figs[figure].canvas.window_pylustrator | |||
| # window = _pylab_helpers.Gcf.figs[figure].canvas.window_pylustrator | |||
There was a problem hiding this comment.
I think there is value to have code lines that are commented out without the space to distinguish them from "real" comments which are annotations
rgerum
reviewed
May 26, 2023
| try: # starting from mpl version 3.6.0 | ||
| from matplotlib.axes import Axes | ||
| except: | ||
| except Exception: |
There was a problem hiding this comment.
Just adding Exception as the exception does not make the except less of a wildcard. I think here the right thing would be ImportError
rgerum
reviewed
May 26, 2023
| @@ -77,7 +82,8 @@ def schedule_draw(self): | |||
| def draw(self): | |||
| self.timer.stop() | |||
| import traceback | |||
There was a problem hiding this comment.
I guess instead of adding an empty line after the import this import should go to the top.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.