Use chunk_samples in SileroVad to avoid InvalidChunkSizeError #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colonelpanic8
force-pushed
the
use-chunk_samples-in-SileroVad
branch
from
293839d to
509628a
Compare
|
@synesthesiam This also fixes some issues with how pyproject.toml is set up (all submodules will be included now), and adds the poetry.lock file to the repo (which is the standard way to do things). |
|
I was also wondering, why there was 1.3.1 in the file but the tag was 1.4.0. Means also the tag needs to be recreated which is not that good but needed. Offtopic: I think we need a good release process and more testing for this project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as suggested here #246 (comment)