Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bin): detect connection refused error and exit early #248

Merged
merged 2 commits into from
Jan 27, 2025
Merged

feat(bin): detect connection refused error and exit early #248

merged 2 commits into from
Jan 27, 2025

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Jan 15, 2025 •
edited
Loading

@xxchan xxchan requested a review from BugenZhao January 15, 2025 05:06
skyzh
skyzh approved these changes Jan 26, 2025
View reviewed changes
Copy link
Member

@skyzh skyzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel in general it doesn't seem like a good idea to match on the error string and do ad-hoc thing for a specific type of error, but given it's in the sqllogictest-bin, it looks fine to me for now.

@xxchan xxchan force-pushed the xxchan/tall-tiglon branch from 9a63081 to 341a1e4 Compare January 27, 2025 04:28
@xxchan xxchan enabled auto-merge (squash) January 27, 2025 04:28
@xxchan xxchan merged commit c3b8c52 into main Jan 27, 2025
4 checks passed
@xxchan xxchan deleted the xxchan/tall-tiglon branch January 27, 2025 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skyzh skyzh skyzh approved these changes

@BugenZhao BugenZhao Awaiting requested review from BugenZhao

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xxchan @skyzh