Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: periodically pull ats addr #1814

Open
wants to merge 1 commit into
base: graphite-base/1814
Choose a base branch
from
Open

fix: periodically pull ats addr #1814

wants to merge 1 commit into from

Conversation

MasterPtato
Copy link
Contributor

@MasterPtato MasterPtato commented Jan 9, 2025 •
edited
Loading

Fixes RVT-4346

Changes

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Jan 9, 2025 •
edited
Loading

Deploying rivet with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8d5d663
Status: ✅  Deploy successful!
Preview URL: https://16f428ef.rivet.pages.dev
Branch Preview URL: https://01-09-fix-periodically-pull.rivet.pages.dev

View logs

This was referenced Jan 9, 2025
Closed
Draft
Closed
Closed
Closed
Closed
@MasterPtato Graphite App
Copy link
Contributor Author

MasterPtato commented Jan 9, 2025 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MasterPtato MasterPtato mentioned this pull request Jan 9, 2025
Closed
@linear Linear
Copy link

linear bot commented Jan 9, 2025

RVT-4346 Make pb manager periodically pull ATS ips

This was referenced Jan 9, 2025
Open
Draft
NathanFlurry
NathanFlurry requested changes Jan 10, 2025
View reviewed changes
packages/infra/client/manager/src/pull_addr_handler.rs
use tokio::sync::RwLock;

/// Duration between pulling addresses again.
const PULL_INTERVAL: Duration = Duration::from_secs(3 * 60 * 60);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be this high? if we taint an ats node, we should have the new ats endpoints come online within a reasonable amount of time. any reason not to do it every minute?

@MasterPtato MasterPtato force-pushed the 01-08-chore_improve_actors_allocated_metric branch from 4786ade to cccd6d9 Compare January 10, 2025 23:59
@MasterPtato MasterPtato force-pushed the 01-09-fix_periodically_pull_ats_addr branch from 1465558 to 8d5d663 Compare January 10, 2025 23:59
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Jan 10, 2025 •
edited
Loading

Deploying rivet-hub with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8d5d663
Status:🚫  Build failed.

View logs

@MasterPtato MasterPtato changed the base branch from 01-08-chore_improve_actors_allocated_metric to graphite-base/1814 January 11, 2025 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NathanFlurry NathanFlurry NathanFlurry requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MasterPtato @NathanFlurry