Simplify GraphQL::Backtrace #5217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
lib/graphql/backtrace/table.rb
Outdated
| end | ||
| end | ||
|
|
||
| if last_part |
There was a problem hiding this comment.
instance method rows missing tests for lines 81, 92, 93, 81, 81, 91 (coverage: 0.907)
| response_list | ||
| rescue NoMethodError => err | ||
| # Ruby 2.2 doesn't have NoMethodError#receiver, can't check that one in this case. (It's been EOL since 2017.) | ||
| if err.name == :each && (err.respond_to?(:receiver) ? err.receiver == value : true) |
There was a problem hiding this comment.
instance method continue_field missing tests for lines 587, 588, 597, 598, 658, 666, 678, 685, 684, 586, 658, 658 (coverage: 0.8649)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could be simplified by adding some info to the existing runtime structures. Then I could scrap a lot of code and simplify the
tracemodule setup, too.TODO:
GraphQLResultwould have shown up in higher memory usage but apparently not. (All the same Ruby objects, but new references to them...)