[MAIN-2678] Fixing missing slack sink workload #1705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arikalon1
reviewed
Jan 26, 2025
| @@ -42,7 +42,7 @@ def handle_notification_grouping(self, finding: Finding, platform_enabled: bool) | |||
| investigate_uri = self.get_timeline_uri(self.account_id, self.cluster_name) | |||
| finding_data = finding.attribute_map | |||
| # The top level entity name (the owner of the pod etc) | |||
| finding_data["workload"] = finding.service.name if finding.service else None | |||
| finding_data["workload"] = finding.service.name if finding.service else finding.backup_workload_name | |||
There was a problem hiding this comment.
why are we doing it only for Slack?
it's probably useful on other places as well
There was a problem hiding this comment.
i saw that workload only exists for slack, we can do this for the robusta sink if you think too
| @@ -67,6 +67,19 @@ def guess_cached_resource(cls, name: str, namespace: str) -> Optional[TopLevelRe | |||
| return cached_resource | |||
| return None | |||
|
|
|||
| @classmethod | |||
| def guess_workload_from_labels(cls, labels: Dict[Any, Any] = None) -> Optional[TopLevelResource]: | |||
There was a problem hiding this comment.
I think this should be part of the guess_cached_resource method
I would just add this logic, in case the existing logic didn't work.
This way, it will also be available to all other places using the returned value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if the workload does not exist, like the pod or deployment is deleted it falls back to using the prometheus labels for sinc matching