Simplify call to RunGraphs using new feature in ROOT's master branch #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
I'll switch to latest ROOT after we'll add ML part. |
We can pass RResultMaps to it now, no need to keep around the nominal result ptr.
It does not work anymore and we can't provide one that works (we need a build of ROOT master branch).
eguiraud
force-pushed
the
improvements-that-require-master
branch
from
32ba11c to
239e85b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this change is committed, the main branch of this repo will stop working with ROOT v6.28.04 and will require a recent build of ROOT's master branch. #32 updates the analysis' README to point this out.
@andriiknu does that work for you?
To do