Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify ML part as fastforest is integrated within RBDT #46

Merged
merged 4 commits into from
Jul 5, 2024
Merged

Modify ML part as fastforest is integrated within RBDT #46

merged 4 commits into from
Jul 5, 2024

Conversation

martamaja10
Copy link
Contributor

Since fastforest was recently integrated with the RBDT library, the ML inference implementation is now modified. It is now not necessary to load fastforest library separately.

@martamaja10 martamaja10 self-assigned this May 31, 2024
guitargeek
guitargeek approved these changes May 31, 2024
View reviewed changes
Copy link

@guitargeek guitargeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

vepadulano
vepadulano requested changes Jul 5, 2024
View reviewed changes
Copy link
Member

@vepadulano vepadulano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the nice improvements, some minor changes before merging. Also, I can see a few errors from the linter in the changed files such as F401 os imported but unused and F541 f-string without any placeholders

analyses/cms-open-data-ttbar/analysis.py Outdated Show resolved Hide resolved
analyses/cms-open-data-ttbar/ml.py Outdated Show resolved Hide resolved
analyses/cms-open-data-ttbar/analysis.py Outdated Show resolved Hide resolved
@martamaja10 martamaja10 force-pushed the AGC_June2024 branch 2 times, most recently from eeb637c to 3b08d0d Compare July 5, 2024 14:27
vepadulano
vepadulano approved these changes Jul 5, 2024
View reviewed changes
Copy link
Member

@vepadulano vepadulano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@martamaja10 martamaja10 merged commit 5d22e87 into main Jul 5, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guitargeek guitargeek guitargeek approved these changes

@vepadulano vepadulano vepadulano approved these changes

Assignees

@martamaja10 martamaja10

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@martamaja10 @guitargeek @vepadulano